1656894 - Update xxHash to version 0.8.0

Status: RESOLVED FIXED

(Core :: MFBT, task)

Description

[Ryan VanderMeulen [:RyanVM]]

+++ This bug was initially created as a clone of Bug #1620433 +++

After more than a year in the making, XXH3 has finally reached stable status, for both its 64-bit and 128-bit variants.
While the code itself was in good enough shape for production use, the generated values could still change between versions. This limited XXH3 to local sessions only.
From now on, output values produced by XXH3 for a given input and parameter set will remain identical across systems and across future versions. It makes it possible to store these values for later comparison, or to exchange them across network connections.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 1656894 - Update xxHash to version 0.8.0. r=dthayer

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Try push:
https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=2a71fdcdf3c78b81766f72626df5134f169e85a0

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6b53d90ee8b4
Update xxHash to version 0.8.0. r=dthayer

Comment 4

[Natalia Csoregi [:nataliaCs]]

Backed out for asan bustage on xxhash.h

backout: https://hg.mozilla.org/integration/autoland/rev/ea8a4b26afc969e80e906a8e6f26458dda70c2fc

push where it failed: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=7c989e4725314871b8ae32fb040a4c9126693f13&searchStr=windows%2C2012%2Cx64%2Casan%2Cbuild-win64-asan%2Fdebug%2Cbd&selectedTaskRun=DJ9BgEIMTAiY5QbFYvLwRA.1

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=311912974&repo=autoland&lineNumber=5757

[task 2020-08-03T19:11:19.063Z] 19:11:19 INFO - In file included from z:/build/build/src/mfbt/lz4/xxhash.c:43:
[task 2020-08-03T19:11:19.063Z] 19:11:19 INFO - z:/build/build/src/mfbt/lz4/xxhash.h(3503,1): error: unused function 'XXH3_accumulate_512_scalar' [-Werror,-Wunused-function]
[task 2020-08-03T19:11:19.064Z] 19:11:19 INFO - XXH3_accumulate_512_scalar(void* XXH_RESTRICT acc,
[task 2020-08-03T19:11:19.064Z] 19:11:19 INFO - ^
[task 2020-08-03T19:11:19.064Z] 19:11:19 INFO - z:/build/build/src/mfbt/lz4/xxhash.h(3521,1): error: unused function 'XXH3_scrambleAcc_scalar' [-Werror,-Wunused-function]
[task 2020-08-03T19:11:19.064Z] 19:11:19 INFO - XXH3_scrambleAcc_scalar(void* XXH_RESTRICT acc, const void* XXH_RESTRICT secret)
[task 2020-08-03T19:11:19.064Z] 19:11:19 INFO - ^
[task 2020-08-03T19:11:19.064Z] 19:11:19 INFO - z:/build/build/src/mfbt/lz4/xxhash.h(3538,1): error: unused function 'XXH3_initCustomSecret_scalar' [-Werror,-Wunused-function]
[task 2020-08-03T19:11:19.064Z] 19:11:19 INFO - XXH3_initCustomSecret_scalar(void* XXH_RESTRICT customSecret, xxh_u64 seed64)
[task 2020-08-03T19:11:19.065Z] 19:11:19 INFO - ^
[task 2020-08-03T19:11:19.065Z] 19:11:19 INFO - 3 errors generated.
[task 2020-08-03T19:11:19.065Z] 19:11:19 INFO - z:/build/build/src/config/rules.mk:668: recipe for target 'xxhash.obj' failed
[task 2020-08-03T19:11:19.065Z] 19:11:19 INFO - mozmake.EXE[4]: *** [xxhash.obj] Error 1
[task 2020-08-03T19:11:19.065Z] 19:11:19 INFO - mozmake.EXE[4]: Leaving directory 'z:/build/workspace/obj-build/mfbt'
[task 2020-08-03T19:11:19.065Z] 19:11:19 INFO - mozmake.EXE[4]: *** Waiting for unfinished jobs....

Comment 5

[Ryan VanderMeulen [:RyanVM]]

FWIW, I'm not sure when I'll have cycles to get back to this. If someone else wants to poke at it, be my guest.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/61554ba5baee
Update xxHash to version 0.8.0. r=dthayer

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/61554ba5baee