1656997 - When session history runs in the parent process, SessionStore should not modify the session history when doing process switches

Status: RESOLVED FIXED

(Firefox :: Session Restore, task)

Description

[Olli Pettay [:smaug][[e-mail]]]

Bug 1656996 has a silly commented out code in session store code to be able to test
session history in parent.

Comment 1

[Alphan Chen [:alchen]]

Let me investigate it first.

Comment 2

[Alphan Chen [:alchen]]

I think it is related to SessionStore::finishTabRemotenessChange().
https://searchfox.org/mozilla-central/rev/b4f3ce16c5099cf068fb023341959a0457adec9e/browser/components/sessionstore/SessionStore.jsm#6065
However, I don't really familiar with this code.

Comment 3

[Alphan Chen [:alchen]]

Attachment: Bug 1656997 - When session history runs in the parent process, SessionStore should not modify the session history when doing process switches

Comment 4

[Alphan Chen [:alchen]]

(In reply to Alphan Chen [:alchen] from comment #2)

I think it is related to SessionStore::finishTabRemotenessChange().
https://searchfox.org/mozilla-central/rev/b4f3ce16c5099cf068fb023341959a0457adec9e/browser/components/sessionstore/SessionStore.jsm#6065

This function will call "this.restoreTab()".
Then "this.restoreTab()" will call "this._sendRestoreHistory" to trigger the history restore.

attachment 9168252 [details] skip the history.restore() if it is a process switch case.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Bug 1656997 - When session history runs in the parent process, SessionStore should not modify the session history when doing process switches, r=nika

Depends on D85789

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c3aaa4f191e6
When session history runs in the parent process, SessionStore should not modify the session history when doing process switches, r=nika

Comment 7

[Natalia Csoregi [:nataliaCs]]

Backed out for fission failures on browser_preferences_usage.js

backout: https://hg.mozilla.org/integration/autoland/rev/3cb2028fb9e10e4cb57c5baf5d6bb5d8fac85ad7

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=c3aaa4f191e6d399e1ee4b509235119385814193&test_paths=browser%2Fbase%2Fcontent%2Ftest%2Fperformance%2Fbrowser.ini&selectedTaskRun=GUmiKXJLRNqWz4pXtroRXg.0

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=312959807&repo=autoland&lineNumber=4130

[task 2020-08-13T21:22:27.888Z] 21:22:27 INFO - TEST-PASS | browser/base/content/test/performance/browser_preferences_usage.js | dom.ipc.keepProcessesAlive.webIsolated.perOrigin should be accessed at most 51 times. - 50 <= 51 -
[task 2020-08-13T21:22:27.888Z] 21:22:27 INFO - Buffered messages finished
[task 2020-08-13T21:22:27.903Z] 21:22:27 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_preferences_usage.js | fission.sessionHistoryInParent should not be accessed more than 40 times. - 50 <= 40 - JS frame :: chrome://mochitests/content/browser/browser/base/content/test/performance/browser_preferences_usage.js :: checkPrefGetters :: line 42
[task 2020-08-13T21:22:27.904Z] 21:22:27 INFO - Stack trace:
[task 2020-08-13T21:22:27.904Z] 21:22:27 INFO - chrome://mochitests/content/browser/browser/base/content/test/performance/browser_preferences_usage.js:checkPrefGetters:42
[task 2020-08-13T21:22:27.905Z] 21:22:27 INFO - chrome://mochitests/content/browser/browser/base/content/test/performance/browser_preferences_usage.js:navigate_around:274
[task 2020-08-13T21:22:27.906Z] 21:22:27 INFO - TEST-PASS | browser/base/content/test/performance/browser_preferences_usage.js | layout.css.dpi should not be accessed more than 40 times. - 14 <= 40 -

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

bah, I did test that locally and didn't get any errors.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dd369ee9cd33
When session history runs in the parent process, SessionStore should not modify the session history when doing process switches, r=nika,mconley

Comment 10

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/dd369ee9cd33