1657066 - Dynamic module import asserts if it encounters an uncatchable exception

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P1)

Description

[Jon Coppeard (:jonco)]

The following test case results in Assertion failure: JS_IsExceptionPending(cx):

let g = newGlobal({newCompartment: true});
new Debugger(g).onExceptionUnwind = () => null;
g.eval(`import("javascript: throw 1")`);

Comment 1

[Jon Coppeard (:jonco)]

Found while working on bug 1510598.

Comment 2

[Jon Coppeard (:jonco)]

Attachment: Bug 1657066 - Dynamic module import doesn't handle uncatchable exceptions r?jandem

Previously this used |cx->isExceptionPending()| to determine whether the import had succeeded, which doesn't work if there was an uncatchable exception. The patch changes this to pass an explicit status.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d24201b6daf7
Dynamic module import doesn't handle uncatchable exceptions r=jandem

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/d24201b6daf7