1657088 - Warp: Optimize code emitted for a simple for-of loop

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P1)

Description

[Tom S. (please needinfo tschuster)]

There are various problems with for-of as compiled by Warp. Probably most importantly we weren't even inlining the JSOp::CallIter call to Array.prototype.[Symbol.iterator]. I think with a bit of work I could even get the scalar replacement for the iterator object working. I want to do this last to not miss some other optimizations.

Comment 1

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1657088 - Do not emit callee guard for some other intrinsics. r?jandem

Comment 2

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1657088 - Do inlining for JSOp::CallIter. r?iain

Depends on D85870

Comment 3

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1657088 - Folding for MIsObject and MCheckIsObj. r?jandem

Depends on D85871

Comment 4

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1657088 - Optimize CheckIsObj in WarpBuilder for known objects. r?jandem

This is useful for scalar replacement / escape analysis, because otherwise
we would have to handle that case there, too.

Depends on D85872

Comment 5

[Tom S. (please needinfo tschuster)]

Attachment: for-of testcase

Comment 6

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1657088 - Change MCheckIsObject to return an Object. r?jandem

Depends on D85871

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3e1d47384b4d
Do inlining for JSOp::CallIter. r=iain
https://hg.mozilla.org/integration/autoland/rev/d3c031931b96
Change MCheckIsObject to return an Object. r=jandem
https://hg.mozilla.org/integration/autoland/rev/ca8852a5f555
Folding for MIsObject and MCheckIsObj. r=jandem
https://hg.mozilla.org/integration/autoland/rev/30945c9bef85
Optimize CheckIsObj in WarpBuilder for known objects. r=jandem

Comment 8

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/3e1d47384b4d
https://hg.mozilla.org/mozilla-central/rev/d3c031931b96
https://hg.mozilla.org/mozilla-central/rev/ca8852a5f555
https://hg.mozilla.org/mozilla-central/rev/30945c9bef85