Closed Bug 1657105 Opened 5 years ago Closed 5 years ago

Allow one resource to be observed from both the parent and the content process

Tracking

(firefox81 fixed)

Status:

RESOLVED FIXED

Milestone:

81 Branch

Tracking Flags:

Tracking

Status

firefox81

---

fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

Details

Attachments

(3 files, 1 obsolete file)

Bug 1657105 - Allow listening for resources from both parent and content processes. 5 years ago Alexandre Poirot [:ochameau] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1657105 - prototype for bug 1644191, listen for stack trace from the content process. 5 years ago Alexandre Poirot [:ochameau] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1657105 - Fix server side update and destroy events. 5 years ago Alexandre Poirot [:ochameau] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1657105 - Use constants to define target types on the server and set targetType on all targets. 5 years ago Alexandre Poirot [:ochameau] 47 bytes, text/x-phabricator-request		Details \| Review

Alexandre Poirot [:ochameau]

Assignee

Description

•

5 years ago

Network event resource is having a unique and special requirement.
Everything related to network requests can only be observed from the parent process.
Everything, but their related stack trace. Stack traces can only be observed from the content process, where the request originates from. Typically, the process where the web page is running.

For now, Watcher Actor only support spawning one "Watcher" class, only in one of the two process type (parent or content).
So here, we would need a way to possibly spawn two Watcher class, one in parent and/or one in content.

Alexandre Poirot [:ochameau]

Assignee

Comment 1

•

5 years ago

Attached file Bug 1657105 - Allow listening for resources from both parent and content processes. — Details

Phabricator Automation

Updated

•

5 years ago

Assignee: nobody → poirot.alex

Status: NEW → ASSIGNED

Alexandre Poirot [:ochameau]

Assignee

Comment 2

•

5 years ago

Attached file Bug 1657105 - prototype for bug 1644191, listen for stack trace from the content process. (obsolete) — Details

Alexandre Poirot [:ochameau]

Assignee

Comment 3

•

5 years ago

Attached file Bug 1657105 - Fix server side update and destroy events. — Details

Phabricator Automation

Updated

•

5 years ago

Attachment #9168229 - Attachment description: Bug 1657105 - Fix server side update and destroy events → Bug 1657105 - Fix server side update and destroy events.

Alexandre Poirot [:ochameau]

Assignee

Comment 4

•

5 years ago

Attached file Bug 1657105 - Use constants to define target types on the server and set targetType on all targets. — Details

Pulsebot

Comment 5

•

5 years ago

Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cc50fc1340a9 Use constants to define target types on the server and set targetType on all targets. r=jdescottes https://hg.mozilla.org/integration/autoland/rev/51b8364f941b Allow listening for resources from both parent and content processes. r=jdescottes,nchevobbe https://hg.mozilla.org/integration/autoland/rev/e0ac6c61d65a Fix server side update and destroy events. r=jdescottes

Bogdan Tara[:bogdan_tara | bogdant]

Comment 6

•

5 years ago

Backed out 3 changesets (bug 1657105) for es lint and test_logpoint-03.js failures

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&fromchange=e0ac6c61d65abb6abdfd56fe3c259a5f1afbe672&searchStr=lint&tochange=b5d31614994e19b92f699d5e14907aaff84e1512&selectedTaskRun=bmqdo9hnQVuQLLtBjxv4ZQ.0

Backout link: https://hg.mozilla.org/integration/autoland/rev/b5d31614994e19b92f699d5e14907aaff84e1512

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=312839055&repo=autoland&lineNumber=111

[task 2020-08-12T15:36:26.547Z] 15:36:26.547 eslint (93) | Passing the following paths:
[task 2020-08-12T15:36:26.547Z] /builds/worker/checkouts/gecko/memory  
[task 2020-08-12T15:36:26.547Z] /builds/worker/checkouts/gecko/hal  
[task 2020-08-12T15:36:26.547Z] /builds/worker/checkouts/gecko/testing  
[task 2020-08-12T15:36:26.548Z] /builds/worker/checkouts/gecko/docs  
[task 2020-08-12T15:36:26.548Z] /builds/worker/checkouts/gecko/docshell  
[task 2020-08-12T15:36:26.548Z] /builds/worker/checkouts/gecko/media  
[task 2020-08-12T15:36:26.548Z] /builds/worker/checkouts/gecko/ipc  
[task 2020-08-12T15:36:26.548Z] /builds/worker/checkouts/gecko/extensions  
[task 2020-08-12T15:36:26.548Z] /builds/worker/checkouts/gecko/modules  
[task 2020-08-12T15:36:26.548Z] /builds/worker/checkouts/gecko/gfx  
[task 2020-08-12T15:36:26.548Z] /builds/worker/checkouts/gecko/devtools  
[task 2020-08-12T15:36:26.548Z] /builds/worker/checkouts/gecko/intl  
[task 2020-08-12T15:36:26.548Z] /builds/worker/checkouts/gecko/startupcache  
[task 2020-08-12T15:36:26.548Z] /builds/worker/checkouts/gecko/storage
[task 2020-08-12T15:36:26.559Z] 15:36:26.558 eslint (93) | Command: /usr/local/bin/node /builds/worker/checkouts/gecko/node_modules/eslint/bin/eslint.js --ext [js,jsm,jsx,xul,html,xhtml] --format json --no-error-on-unmatched-pattern --quiet --ignore-pattern media/webrtc/trunk --ignore-pattern media/mtransport/third_party --ignore-pattern media/webrtc/signaling/src/sdp/sipcc --ignore-pattern media/libvorbis --ignore-pattern testing/xpcshell/dns-packet --ignore-pattern gfx/qcms --ignore-pattern intl/unicharutil/util/nsSpecialCasingData.cpp --ignore-pattern testing/modules/ajv-4.1.1.js --ignore-pattern testing/mozbase/mozproxy/mozproxy/backends/mitm/scripts/catapult --ignore-pattern devtools/shared/acorn --ignore-pattern devtools/shared/qrcode/encoder --ignore-pattern gfx/angle/checkout --ignore-pattern testing/talos/talos/tests/dromaeo --ignore-pattern devtools/shared/qrcode/decoder --ignore-pattern media/libyuv --ignore-pattern devtools/client/shared/demangle.js --ignore-pattern gfx/skia --ignore-pattern intl/unicharutil/util/nsUnicodeScriptCodes.h --ignore-pattern intl/unicharutil/util/nsUnicodePropertyData.cpp --ignore-pattern devtools/client/shared/sourceeditor/test/codemirror --ignore-pattern devtools/shared/sprintfjs --ignore-pattern testing/mochitest/tests/MochiKit-1.4.2 --ignore-pattern devtools/client/shared/sourceeditor/codemirror --ignore-pattern media/libnestegg --ignore-pattern gfx/vr/service/openvr --ignore-pattern gfx/harfbuzz --ignore-pattern devtools/client/jsonview/lib/require.js --ignore-pattern devtools/shared/node-properties --ignore-pattern testing/talos/talos/tests/v8_7 --ignore-pattern media/openmax_il --ignore-pattern media/libwebp --ignore-pattern media/libjpeg --ignore-pattern gfx/graphite2 --ignore-pattern extensions/spellcheck/hunspell/src --ignore-pattern gfx/cairo --ignore-pattern media/mp4parse-rust --ignore-pattern testing/web-platform/tests/tools/third_party --ignore-pattern testing/talos/talos/tests/kraken --ignore-pattern media/libtremor --ignore-pattern modules/fdlibm --ignore-pattern media/libopus --ignore-pattern gfx/sfntly --ignore-pattern gfx/ots --ignore-pattern testing/web-platform/tests/resources/webidl2 --ignore-pattern testing/gtest/gmock --ignore-pattern testing/gtest/gtest --ignore-pattern modules/woff2 --ignore-pattern devtools/client/shared/build/babel.js --ignore-pattern devtools/shared/jsbeautify --ignore-pattern media/libmkv --ignore-pattern gfx/ycbcr --ignore-pattern media/libcubeb --ignore-pattern modules/xz-embedded --ignore-pattern ipc/chromium/src/third_party --ignore-pattern modules/zlib --ignore-pattern devtools/client/shared/source-map --ignore-pattern media/libsoundtouch --ignore-pattern devtools/client/debugger/flow-typed/npm --ignore-pattern modules/freetype2 --ignore-pattern gfx/wr --ignore-pattern devtools/client/shared/vendor --ignore-pattern media/libspeex_resampler --ignore-pattern media/openmax_dl --ignore-pattern media/libpng --ignore-pattern media/ffvpx --ignore-pattern media/kiss_fft --ignore-pattern media/libogg --ignore-pattern modules/brotli --ignore-pattern testing/xpcshell/node-ip --ignore-pattern devtools/shared/heapsnapshot/CoreDump.pb.h --ignore-pattern testing/modules/sinon-7.2.7.js --ignore-pattern devtools/shared/heapsnapshot/CoreDump.pb.cc --ignore-pattern devtools/client/shared/sourceeditor/test/cm_mode_ruby.js --ignore-pattern media/libaom --ignore-pattern testing/mochitest/pywebsocket3 --ignore-pattern intl/icu --ignore-pattern media/libdav1d --ignore-pattern media/libtheora --ignore-pattern testing/xpcshell/node-http2 --ignore-pattern testing/mochitest/MochiKit --ignore-pattern media/libvpx --ignore-pattern devtools/shared/storage/vendor /builds/worker/checkouts/gecko/memory /builds/worker/checkouts/gecko/hal /builds/worker/checkouts/gecko/testing /builds/worker/checkouts/gecko/docs /builds/worker/checkouts/gecko/docshell /builds/worker/checkouts/gecko/media /builds/worker/checkouts/gecko/ipc /builds/worker/checkouts/gecko/extensions /builds/worker/checkouts/gecko/modules /builds/worker/checkouts/gecko/gfx /builds/worker/checkouts/gecko/devtools /builds/worker/checkouts/gecko/intl /builds/worker/checkouts/gecko/startupcache /builds/worker/checkouts/gecko/storage
[task 2020-08-12T15:38:07.899Z] 15:38:07.898 eslint (92) | Finished in 101.59 seconds
[task 2020-08-12T15:42:53.613Z] 15:42:53.612 eslint (94) | Finished in 387.30 seconds
[task 2020-08-12T15:43:58.464Z] 15:43:58.464 eslint (93) | Finished in 452.16 seconds
[task 2020-08-12T15:46:26.601Z] 15:46:26.600 eslint (91) | Finished in 600.30 seconds
[task 2020-08-12T15:46:26.605Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/devtools/server/actors/resources/index.js:76:23 | Replace `⏎········`Unsupported·target·actor·typeName·'${targetType}'`⏎······` with ``Unsupported·target·actor·typeName·'${targetType}'`` (prettier/prettier)
[taskcluster 2020-08-12 15:46:26.956Z] === Task Finished ===
[taskcluster 2020-08-12 15:46:27.151Z] Unsuccessful task run with exit code: 1 completed in 627.647 seconds

Also seeing the following failing on Test Verify:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&fromchange=e0ac6c61d65abb6abdfd56fe3c259a5f1afbe672&searchStr=TV&tochange=b5d31614994e19b92f699d5e14907aaff84e1512&selectedTaskRun=J-WlsU5yQgidBe2TEQLlCA.0

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=312842042&repo=autoland&lineNumber=1698

[task 2020-08-12T15:51:07.453Z] 15:51:07     INFO -  SUITE-START | Running 1 tests
[task 2020-08-12T15:51:07.472Z] 15:51:07     INFO -  TEST-START | devtools/server/tests/xpcshell/test_logpoint-03.js
[task 2020-08-12T15:51:07.712Z] 15:51:07  WARNING -  TEST-UNEXPECTED-FAIL | devtools/server/tests/xpcshell/test_logpoint-03.js | xpcshell return code: 0
[task 2020-08-12T15:51:07.712Z] 15:51:07     INFO -  TEST-INFO took 241ms
[task 2020-08-12T15:51:07.712Z] 15:51:07     INFO -  >>>>>>>
[task 2020-08-12T15:51:07.712Z] 15:51:07     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2020-08-12T15:51:07.712Z] 15:51:07     INFO -  (xpcshell/head.js) | test run_next_test 0 pending (2)
[task 2020-08-12T15:51:07.712Z] 15:51:07     INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
[task 2020-08-12T15:51:07.712Z] 15:51:07     INFO -  running event loop
[task 2020-08-12T15:51:07.712Z] 15:51:07     INFO -  devtools/server/tests/xpcshell/test_logpoint-03.js | Starting
[task 2020-08-12T15:51:07.712Z] 15:51:07     INFO -  (xpcshell/head.js) | test pending (2)
[task 2020-08-12T15:51:07.713Z] 15:51:07     INFO -  PID 6172 | >>> Run thread front test against a regular DevToolsServer
[task 2020-08-12T15:51:07.713Z] 15:51:07     INFO -  (xpcshell/head.js) | test run_next_test 0 finished (2)
[task 2020-08-12T15:51:07.713Z] 15:51:07     INFO -  TEST-PASS | devtools/server/tests/xpcshell/test_logpoint-03.js |  - Thread client is paused - "paused" == "paused"
[task 2020-08-12T15:51:07.713Z] 15:51:07     INFO -  TEST-PASS | devtools/server/tests/xpcshell/test_logpoint-03.js |  - true == true
[task 2020-08-12T15:51:07.713Z] 15:51:07     INFO -  TEST-PASS | devtools/server/tests/xpcshell/test_logpoint-03.js |  - "attached" == "attached"
[task 2020-08-12T15:51:07.713Z] 15:51:07     INFO -  Unexpected exception Error: Unsupported target actor typeName 'undefined' at resource://devtools/server/actors/resources/index.js:76
[task 2020-08-12T15:51:07.713Z] 15:51:07     INFO -  getResourceTypeDictionary@resource://devtools/server/actors/resources/index.js:76:13
[task 2020-08-12T15:51:07.713Z] 15:51:07     INFO -  getResourceTypeEntry@resource://devtools/server/actors/resources/index.js:92:41
[task 2020-08-12T15:51:07.713Z] 15:51:07     INFO -  watchResources@resource://devtools/server/actors/resources/index.js:125:60
[task 2020-08-12T15:51:07.713Z] 15:51:07     INFO -  @Z:/task_1597246339/build/tests/xpcshell/tests/devtools/server/tests/xpcshell/test_logpoint-03.js:26:15
[task 2020-08-12T15:51:07.714Z] 15:51:07     INFO -  runThreadFrontTestWithServer@Z:/task_1597246339/build/tests/xpcshell/tests/devtools/server/tests/xpcshell/head_dbg.js:912:13
[task 2020-08-12T15:51:07.714Z] 15:51:07     INFO -  _do_main@Z:\task_1597246339\build\tests\xpcshell\head.js:248:6
[task 2020-08-12T15:51:07.714Z] 15:51:07     INFO -  _execute_test@Z:\task_1597246339\build\tests\xpcshell\head.js:577:5
[task 2020-08-12T15:51:07.714Z] 15:51:07     INFO -  @-e:1:1
[task 2020-08-12T15:51:07.714Z] 15:51:07     INFO -  exiting test
[task 2020-08-12T15:51:07.714Z] 15:51:07     INFO -  <<<<<<<

Flags: needinfo?(poirot.alex)

Alexandre Poirot [:ochameau]

Assignee

Comment 7

•

5 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=11396bd925ec141489c76361e56e220cb56606bd

Flags: needinfo?(poirot.alex)

Bogdan Tara[:bogdan_tara | bogdant]

Comment 8

•

5 years ago

The Test Verify failure popped up on Tier 1: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=312845527&repo=autoland&lineNumber=5860

Alexandre Poirot [:ochameau]

Assignee

Comment 9

•

5 years ago

Thanks, yes this test was permafailing!

Pulsebot

Comment 10

•

5 years ago

Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/873d4b1891cf Use constants to define target types on the server and set targetType on all targets. r=jdescottes https://hg.mozilla.org/integration/autoland/rev/5beaac8623dd Allow listening for resources from both parent and content processes. r=jdescottes,nchevobbe https://hg.mozilla.org/integration/autoland/rev/a0ed52a4de5e Fix server side update and destroy events. r=jdescottes

Alexandru Michis [:malexandru]

Comment 11

•

5 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/873d4b1891cf
https://hg.mozilla.org/mozilla-central/rev/5beaac8623dd
https://hg.mozilla.org/mozilla-central/rev/a0ed52a4de5e

Status: ASSIGNED → RESOLVED

Closed: 5 years ago

status-firefox81: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 81 Branch

Phabricator Automation

Updated

•

5 years ago

Attachment #9168228 - Attachment is obsolete: true

You need to log in before you can comment on or make changes to this bug.

Bugzilla

Allow one resource to be observed from both the parent and the content process

Categories

(DevTools :: Framework, enhancement)

Tracking

(firefox81 fixed)

People

(Reporter: ochameau, Assigned: ochameau)

References

Details

Crash Data

Security

(public)

User Story

Attachments

(3 files, 1 obsolete file)

Description

Comment 1

Updated

Comment 2

Comment 3

Updated

Comment 4

Comment 5

Comment 6

Comment 7

Comment 8

Comment 9

Comment 10

Comment 11

Updated

Attachment

General

Description

File Name

Content Type