Closed Bug 1657154 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 24874 - Python 3: Use OrderedDict type to generate same test names

Categories

(Testing :: geckodriver, task, P4)

task

Tracking

(firefox81 fixed)

RESOLVED FIXED
81 Branch
Tracking Status
firefox81 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 24874 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/24874
Details from upstream follow.

Ziran Sun <zsun@igalia.com> wrote:

Python 3: Use OrderedDict type to generate same test names

In Python 2, dict is organized via a hash-table and puts the keys
into buckets according to their hash() value.
in Python 3.6+, dict retains insertion order
This patch uses OrderedDict type instead the original Dict to make
sure the same test names generated for both PY2 and PY3

Component: web-platform-tests → geckodriver

CI Results

Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 16 tests and 1 subtests

Status Summary

Firefox

OK : 16
PASS : 178
FAIL : 18

Chrome

OK : 16
PASS : 168
FAIL : 28

Safari

OK : 15
PASS : 100
FAIL : 64
TIMEOUT: 1
ERROR : 31

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/webdriver/tests/perform_actions/key_events.py
test_special_key_sends_keydown[NUMPAD5-expected38]: FAIL
test_special_key_sends_keydown[PAGE_DOWN-expected43]: FAIL
test_special_key_sends_keydown[NUMPAD4-expected37]: FAIL
test_special_key_sends_keydown[PAGE_UP-expected44]: FAIL
test_special_key_sends_keydown[SUBTRACT-expected66]: FAIL
test_special_key_sends_keydown[META-expected30]: FAIL
test_modifier_key_sends_correct_events[\ue03d-META]: FAIL
test_special_key_sends_keydown[ADD-expected0]: FAIL

New Tests That Don't Pass

/webdriver/tests/perform_actions/pointer_tripleclick.py
test_tripleclick_at_coordinates: FAIL (Chrome: FAIL)
/webdriver/tests/perform_actions/key_events.py
test_special_key_sends_keydown[NUMPAD5-expected38]: FAIL (Chrome: PASS, Safari: PASS)
test_special_key_sends_keydown[PAGE_DOWN-expected43]: FAIL (Chrome: PASS, Safari: PASS)
test_special_key_sends_keydown[NUMPAD4-expected37]: FAIL (Chrome: PASS, Safari: PASS)
test_special_key_sends_keydown[PAGE_UP-expected44]: FAIL (Chrome: PASS, Safari: PASS)
test_special_key_sends_keydown[SUBTRACT-expected66]: FAIL (Chrome: PASS, Safari: PASS)
test_special_key_sends_keydown[META-expected30]: FAIL (Chrome: PASS, Safari: PASS)
test_modifier_key_sends_correct_events[\ue053-R_META]: FAIL (Chrome: PASS, Safari: FAIL)
test_special_key_sends_keydown[R_META-expected58]: FAIL (Chrome: PASS, Safari: FAIL)
test_modifier_key_sends_correct_events[\ue03d-META]: FAIL (Chrome: PASS, Safari: PASS)
test_special_key_sends_keydown[ADD-expected0]: FAIL (Chrome: PASS, Safari: PASS)
test_special_key_sends_keydown[SEPARATOR-expected63]: FAIL (Chrome: PASS, Safari: FAIL)
/webdriver/tests/perform_actions/validity.py
test_pause_positive_integer[key]: FAIL (Chrome: PASS, Safari: ERROR)
test_pause_positive_integer[none]: FAIL (Chrome: PASS, Safari: ERROR)
test_pause_positive_integer[pointer]: FAIL (Chrome: PASS, Safari: ERROR)
/webdriver/tests/perform_actions/pointer.py
test_drag_and_drop_with_draggable_element[0]: FAIL (Chrome: FAIL, Safari: FAIL)
test_drag_and_drop_with_draggable_element[300]: FAIL (Chrome: FAIL, Safari: FAIL)
test_drag_and_drop_with_draggable_element[800]: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/03572be85326 [wpt PR 24874] - Python 3: Use OrderedDict type to generate same test names, a=testonly https://hg.mozilla.org/integration/autoland/rev/5d44b61420b2 [wpt PR 24874] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6265f2157956 [wpt PR 24874] - Python 3: Use OrderedDict type to generate same test names, a=testonly https://hg.mozilla.org/integration/autoland/rev/503d08931121 [wpt PR 24874] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
You need to log in before you can comment on or make changes to this bug.