1657166 - Prevent accidently blocking images via SeaMonkey mailcontext and context popup menu.

Status: RESOLVED FIXED

(SeaMonkey :: Passwords & Permissions, task)

Description

[Frank-Rainer Grahl (:frg)]

User now and then manage to block images via the popup menu. The block and unblock items are just too near to view and copy image and if you are a bit careless this happens.
I think moving them under a separater should fix this for almost all cases. Some users might still need them so we donÄt want to remove the items.

Also a comment in the mailcontext popup states wrongly that this is not used and the enable/disable code there causes the exact problems mentioned with working only on second open so update this too.

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1657166-blockimagesep-2535.patch

[Approval Request Comment]
Regression caused by (bug #): --
User impact if declined: support issues/calls with broken websites
Testing completed (on m-c, etc.): 2.53.5
Risk to taking this patch (and alternatives if risky): moderate so lets not take it to 2.53.4
String changes made by this patch: none

Comment 2

[Ian Neal]

Comment on attachment 9167950 [details] [diff] [review]
1657166-blockimagesep-2535.patch

>+++ b/suite/mailnews/content/mailContextMenus.js
>+/**
>+ * Hide a separator based on whether there are any non-hidden items between
>+ * it and the previous separator.
>+ *
>+ * @param aSeparatorID  The id of the separator element.
>+ */
>+function hideIfAppropriate(aSeparatorID) {
>+  ShowMenuItem(aSeparatorID, shouldShowSeparator(aSeparatorID));
Can we not just make use of the nsContextMenu's shouldShowSeparator function here rather than having a duplicate one in mailnews?

r/a=me with that addressed

Comment 3

[Frank-Rainer Grahl (:frg)]

Attachment: 1657166-blockimagesep-v1_1-2535.patch

Version 1.1. Use shouldShowSeparater from nsContextMenu.js and update its comment and body (var -> let).

r/a+ from IanN retained

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/726dd53ea621
Move block image context menu items to separate entry and cleanup mail context menu handling. r=IanN

Comment 5

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/588f256cb8103e04799e13ac4c00099ddec4dc7b