Closed Bug 1657195 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 24877 - Revert "[WPT] Test script's base URL used in dynamic imports"

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox81 fixed)

Status:
RESOLVED FIXED
Milestone:
81 Branch
Tracking Flags:
Tracking Status
firefox81 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 24877 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/24877
Details from upstream follow.

Rebekah Potter <rbpotter@chromium.org> wrote:

Revert "[WPT] Test script's base URL used in dynamic imports"

This reverts commit 7e3a7255699cf3f8ac9bd3e31dadc69db293e06b.

Reason for revert: Consistent failures of
external/wpt/html/semantics/scripting-1/the-script-element/module/dynamic-import/alpha/base-url-worker.sub.html
in blink_web_tests on multiple builders started after this change landed.

Original change's description:

[WPT] Test script's base URL used in dynamic imports

This CL checks base URL used in resolving relative URL-like
specifiers in dynamic imports() from

  • \<script>s,
  • worker top-level scripts, and
  • worker scripts imported by importScripts().

This is for https://github.com/whatwg/html/issues/5751.

Bug: 1082086
Change-Id: I778fb4d34b2e61f57799600006963c93aee5272c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2198835
Commit-Queue: Hiroshige Hayashizaki \<hiroshige@chromium.org>
Reviewed-by: Domenic Denicola \<domenic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#794492}

TBR=hiroshige@chromium.org,domenic@chromium.org

Change-Id: I2fd1c341c96d0364a6dbe6cce31a8c2630403b27
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1082086
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335460
Reviewed-by: Rebekah Potter \<rbpotter@chromium.org>
Commit-Queue: Rebekah Potter \<rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#794657}

PR 24877 applied with additional changes from upstream: c0ae1f6ad4f4dd84d7fb155fff94bd6a882d4513
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f39400495c95 [wpt PR 24877] - Revert "[WPT] Test script's base URL used in dynamic imports", a=testonly
Test result changes from PR not available.
Test result changes from PR not available.
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/57e86fee309c [wpt PR 24877] - Revert "[WPT] Test script's base URL used in dynamic imports", a=testonly

https://hg.mozilla.org/mozilla-central/rev/57e86fee309c

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox81: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
You need to log in before you can comment on or make changes to this bug.