1657225 - mozregression cannot launch Thunderbird builds - js.exe does not contain a valid binary

Status: RESOLVED FIXED

(Testing :: mozregression, defect)

Description

[Asif Youssuff]

Attachment: image.png

Downloaded the latest mozregression to try to find an issue in thunderbird, and it fails when trying to launch any build with: js.exe does not contain a valid binary.

Comment 1

[Ian Moody [:Kwan] (UTC+0)]

Whoops, my bad, apologies. This was an accident due to some changes when implementing firefox l10n builds, so regressed in 4.0.9. If it's usable 4.0.8 should still work for TB regression finding for now.

Commit 6c7da9d1a97aea92591b7db3f407189444176c8b made url_links return full URLs rather than just the last section of the path, and while I tightened regexs in some places it obviously wasn't enough. I think this has only bitten thunderbird due to the alphabetical ordering of the nightly build pages, where firefox comes before jsshell so gets matched first, but thunderbird comes after so jsshell has already matched (compare https://archive.mozilla.org/pub/thunderbird/nightly/2020/02/2020-02-05-10-45-37-comm-central/ with https://archive.mozilla.org/pub/firefox/nightly/2020/02/2020-02-01-09-28-06-mozilla-central/).

Currently the regex that gets built is (target|thunderbird.*win64(-x86_64)?)\.zip$, which matches against a tb jsshell link such as https://archive.mozilla.org/pub/thunderbird/nightly/2020/02/2020-02-05-10-45-37-comm-central/jsshell-win64.zip like so:

regex	url
	https://archive.mozilla.org/pub/
thunderbird	thunderbird
.*	/nightly/2020/02/2020-02-05-10-45-37-comm-central/jsshell-
win64(-x86_64)?	win64
\.zip$	.zip

whereas before testing against just jsshell-win64.zip would have failed. This is easily fixed by either tightening the regex so .* is replaced with [^/]*, or only testing against the result of os.path.basename() on the link, which as it happens is what IntegrationInfoFetcher does for artifact links.

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: [GitHub PR] Bug 1657225 - Check nightly build regexs against filenames, not whole URLs

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:wlach, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 4

[William Lachance (:wlach)]

Will be in next release