Closed Bug 1657309 Opened 5 years ago Closed 5 years ago

Two extra onboarding "IMPRESSION" pings are logged at start up/page load

Categories

(Firefox :: Messaging System, defect)

Desktop
All
defect

Tracking

()

RESOLVED INVALID
Tracking Status
firefox79 --- unaffected
firefox80 --- wontfix
firefox81 --- wontfix

People

(Reporter: cmuresan, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

[Affected versions]:

  • Firefox Beta 80.0b3, Build ID 20200803045446
  • Firefox Nightly 81.0a1, Build ID 20200803094100

[Affected Platforms]:

  • Windows 10
  • macOS 10.15
  • Linux MX 4.19

[Prerequisites]:

  • Have a user.js file with the following line saved user_pref("browser.ping-centre.log", true);.

[Steps to reproduce]:

  1. Create a new Firefox Beta profile with the --jsconsole argument but DO NOT open it.
  2. Navigate to the local profile folder and place the user.js file from prerequisites there.
  3. Start the newly created profile and observe the Browser Console.

[Expected results]:

  • The IMPRESSION ping for the MULTI-STAGE-WELCOME-IMPORTABLE-THEME_AW_GET_STARTED slide/page is displayed.

[Actual results]:

  • The MULTI-STAGE-WELCOME-IMPORTABLE-THEME_AW_GET_STARTED, MULTI-STAGE-WELCOME-IMPORTABLE-THEME, and MULTI-STAGE-WELCOME-IMPORTABLE-THEME_SITES IMPRESSION pings are displayed.

[Notes]:

  • The issue is also reproducible when refreshing the about:welcome page on any slide.
  • Attached a screen recording of the issue.

This is expected behavior since Fx 78 and logged in Tech plan Telemetry section https://docs.google.com/document/d/1EZHx1-qnXyCDWiH7GqgBvis8iEmqXtKgCwITZg9iY1E/edit#heading=h.h2fxax9w7ve

When about:welcome loads, we send impression pings for
a) Welcome UI is loading with message id MULTI-STAGE-WELCOME-IMPORTABLE-THEME
b) Impression respective to screen e.g. MULTI-STAGE-WELCOME-IMPORTABLE-THEME_AW_GET_STARTED
c) Pre-imported sites Impression ping MULTI-STAGE-WELCOME-IMPORTABLE-THEME_SITES

With simplified card experience with message_id ABOUT_WELCOME going away in Fx80, we can refactor and remove 'MULTI-STAGE-WELCOME-IMPORTABLE-THEME' impression ping as it will be redundant and same as 'MULTI-STAGE-WELCOME-IMPORTABLE-THEME_AW_GET_STARTED' for multistage

As logged above, closing bug as works expected, thanks

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WORKSFORME
Resolution: WORKSFORME → INVALID
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: