1657310 - Attach target and related thread from TargetList

Status: RESOLVED FIXED

(DevTools :: Framework, task, P1)

Description

[Nicolas Chevobbe [:nchevobbe]]

In Bug 1633727, we moved attaching to target and thread from the debugger to the toolbox.
In the toolbox, it's done in the TargetList's onTargetAvailable callback.
This can be an issue because the toolbox TargetList instance is only one of the existing instances running for a given session, and could lead to races.
Moving the attaching phase directly to the TargetList itself would make it more safe, as all consumers could expect the targetList to be attached at the moment onTargetAvailable is called.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1657310 - Attach target and thread from TargetList. r=jdescottes,ochameau.

Comment 2

[Chris Peterson [:cpeterson]]

Tracking dt-fission-m2-mvp bugs for Fission Nightly milestone (M6c).

Comment 3

[Neha Kochar [:neha]]

devtools so M6c

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2839eaa25b4e
Attach target and thread from TargetList. r=jdescottes,ochameau.

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/2839eaa25b4e

Comment 7

[Julien Cristau [:jcristau]]

Sebastian let's back this out for the regressions please (also in beta) if we can't disable it.

Comment 8

[Nicolas Chevobbe [:nchevobbe]]

We can probably disable the tests for now.
The failures are all from a specific area in the code, I'll try to go over it soon.

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Regressions fixed in bug 1660466.