1657323 - Unused "Infallible" DNSv6 check failing. Change "mozilla.org" to "detectportal.firefox.com", which has IPv6

Status: RESOLVED FIXED

(Core :: Networking: DNS, defect, P3)

Description

[mcccs]

The variable mDNSv6 is unused 1 except for this method which is tagged "infallible": but I don't know if it's called 2

and it has a wrong value since the value for "network.connectivity-service.DNSv6.domain", which is "mozilla.org" has no AAAA record. If we need that variable to be correct, we could change it to "detectportal.firefox.com"

(I found this while working on Bug 1538477 . It doesn't need this either)

Comment 1

[Honza Bambas (:mayhemer)]

Valentin, I believe this is your code. What do you think?

Comment 2

[Valentin Gosu [:valentin] (he/him) {{ AFK in July }}]

Indeed. I think I didn't go with the detectportal.firefox.com domain because sometimes that's blocked.
I think we ought to use example.org instead. That seems to have a AAAA record. (though it is a bit weird mozilla.org doesn't have one)
Fortunately since we don't really use that result that much, we didn't have any problems from this.

Comment 3

[Valentin Gosu [:valentin] (he/him) {{ AFK in July }}]

Attachment: Bug 1657323 - Do DNS queries for example.org instead of mozilla.org because mo doesn't have IPv6 addresses r=#necko

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b42e3981551
Do DNS queries for example.org instead of mozilla.org because mo doesn't have IPv6 addresses r=necko-reviewers,kershaw

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/3b42e3981551

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.

Comment 7

[Valentin Gosu [:valentin] (he/him) {{ AFK in July }}]

Since we don't actually use the DNSv6 result for anything yet, no point in uplifting. This is just something we may need in the future.