1657353 - Move ObjLiteralStencil out of ScriptThingVariant

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Ted Campbell [:tcampbell]]

This is currently bloating the size of the ScriptThingVariant by more than 10x. We should move it out-of-band to a vector in the CompilationInfo similar to how bigint/regexp are handled.

Comment 1

[Ted Campbell [:tcampbell]]

Attachment: Bug 1657353 - Move ObjLiteralStencil out of ScriptThingVariant. r?arai

This type was ballooning the size of the variant, but could instead be put
out-of-band in a vector on the CompilationInfo. This change also makes the
case more similar to BigInt / RegExp.

Depends on D86007

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9f646bc5b763
Move ObjLiteralStencil out of ScriptThingVariant. r=arai

Comment 3

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/9f646bc5b763

Comment 4

[Andra Esanu (needinfo me)]

== Change summary for alert #26696 (as of Tue, 11 Aug 2020 08:00:40 GMT) ==

Improvements:

2% Base Content Explicit linux1804-64-shippable-qr opt 13,447,936.00 -> 13,149,013.33
2% Base Content Explicit linux1804-64-shippable-qr opt 13,433,514.67 -> 13,151,744.00

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=26696

Comment 5

[Florin Strugariu [:Bebe]]

== Change summary for alert #26696 (as of Tue, 11 Aug 2020 08:00:40 GMT) ==

Improvements:

2% Base Content Explicit linux1804-64-shippable opt 13,191,680.00 -> 12,888,746.67
2% Base Content Explicit linux1804-64-shippable-qr opt 13,447,936.00 -> 13,149,013.33
2% Base Content Explicit linux1804-64-shippable-qr opt 13,433,514.67 -> 13,151,744.00
2% Base Content Explicit linux1804-64-shippable opt 13,113,173.33 -> 12,855,637.33
0.49% Base Content JS macosx1014-64-shippable opt 3,509,860.67 -> 3,492,752.67
0.48% Base Content JS windows10-64-shippable-qr opt 3,510,642.00 -> 3,493,816.00
0.47% Base Content JS linux1804-64-shippable-qr opt 3,504,748.00 -> 3,488,149.33
0.44% Base Content JS linux1804-64-shippable opt 3,503,560.00 -> 3,488,149.33
0.41% Base Content JS linux1804-64-shippable opt 3,500,837.33 -> 3,486,609.33

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=26696