1657419 - support signing other types of promoted addon than recommended

Status: RESOLVED FIXED

(Cloud Services :: Operations: Autograph, task)

Description

[Andrew Williamson [:eviljeff]]

Addons are expanding the Recommended Add-on programme to be Promoted Add-ons, which will other include recommended add-ons, and other classes which have (generally lesser) status. There is already a states array which can include "recommended"; we would need "sponsored", "verified", "line" too.

PRD: https://docs.google.com/document/d/1QpEfiiAnfoEGsJuDbYe69WfYoQ_f_9DqPhK3VKWv9kc/edit# - I copied the relevant section into https://github.com/mozilla/addons-server/issues/14863

summary table: https://docs.google.com/spreadsheets/d/1ENbv1CuLDd25Sk0XAwgbWTl9is5rV12OxJD6g1kUi48/edit#gid=1788006942

We currently pass ['options']['recommendations'] = ['recommended'] to the signing endpoint so would it just be passing a different value instead?

Comment 1

[Andrew Williamson [:eviljeff]]

Oh, we've checked and we never actually used "partner", so that can be removed as a possible state. Leaving "recommended", "sponsored", "verified", "line" (+ "standard"? from https://github.com/mozilla-services/autograph/blob/master/autograph.yaml#L986)

Comment 2

[Bob Micheletto [:bobm]]

Assigning this bug to :gguthe.

Comment 3

[Andrew Williamson [:eviljeff]]

created PR to update the config file as requested by @jvehent
https://github.com/mozilla-services/autograph/pull/509

Comment 4

[Greg G]

Thanks! I'll land the dev changes before tagging the next release (waiting on CI and dep updates).

Updated the stage and prod configs for train-14 in autograph-hiera-sops commit 4f84158753605449e0bb35f7f25f822e5e1adabf

Comment 5

[Greg G]

Changes landed in all envs will deploy with train-14

Comment 6

[Hal Wine [:hwine] use NI!]

(In reply to Andrew Williamson [:eviljeff] from comment #1)

(+ "standard"? from https://github.com/mozilla-services/autograph/blob/master/autograph.yaml#L986)

Note that "standard" is not used per :eviljeff in slack just now

Comment 7

[Greg G]

PR to remove "standard" state from the example/default autograph config https://github.com/mozilla-services/autograph/pull/516