1657435 - Replace uses of nsDocShell::GetAllDocShellsInSubtree() in devtools/server/

Status: RESOLVED FIXED

(DevTools :: Framework, task)

Description

[u608768]

It currently has 2 usages:

1. BrowsingContextTargetActor.docShells, and
2. Timeline.docShells.

We've added an analogous helper to BrowsingContext (getAllBrowsingContextsInSubtree), so this could be as easy as calling that instead and then mapping the results to their respective docShells. It might also make sense to have the callers operate directly on BrowsingContexts instead.

Comment 1

[Chris Peterson [:cpeterson]]

Adding dt-fission whiteboard tag to DevTools bugs that mention Fission or block Fission meta bugs but don't already have a dt-fission whiteboard tag.

Comment 2

[u608768]

I'm uncertain if the 2 usages from comment 0 will be used to interact with out-of-process docshells. Alex, do you know? If they won't, we don't plan on removing GetAllDocShellsInSubtree any time soon, so we can WONTFIX this bug.

Comment 3

[Alexandre Poirot [:ochameau]]

We know that getAllDocShellsInSubtree only iterate over in-same-process children. That may actually be the very first thing we saw when testing fission for the first time. Then the vast majority of DevTools refactorings actually relates to that fact :)

May be we can at least add a comment about that, that these two calls to getAllDocShellsInSubtree are only expecting to iterate over same-process docshells?
Also, I'm wondering if that would be any helpful to migrate to getAllBrowsingContextsInSubtree, while still covering only same-process dochsells.
Would it help doing some other platform cleanups?

Comment 4

[Neha Kochar [:neha]]

Since it works fine as is, we can clean up in M7 and actually remove the usage for getAllDocShellsInSubtree.

Comment 5

[Neha Kochar [:neha]]

Bulk change of all bugs with whiteboard tag of dt-fission to Fission MVP milestone.

Comment 6

[Neha Kochar [:neha]]

Alex, what is the next step here? And should this really block M7 (starting Fission Beta experiments)?

Comment 7

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1657435 - [devtools] Migrate from getAllDocShellsInSubtree to getAllBrowsingContextsInSubtree in DevTools.

Comment 8

[Alexandre Poirot [:ochameau]]

This is just for the cleanup, this code only expects to brower the in-process iframes.
But at least, we are using BrowsingContext API and can feel free to remove the getAllDocShellsInSubtree method if that helps any cleanup.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e4e85cdc014b
[devtools] Migrate from getAllDocShellsInSubtree to getAllBrowsingContextsInSubtree in DevTools. r=nchevobbe

Comment 10

[Chris Peterson [:cpeterson]]

Moving some dt-fission-m3-mvp bugs from Fission MVP to M7 (blocking Beta experiment).

Comment 11

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/e4e85cdc014b