1657445 - [wptserve] Content-Length header missing when response is a file object

Status: NEW

(Testing :: web-platform-tests, defect, P3)

Description

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Whilst investigating bug 1600034 I noticed that wptserve does not include a Content-Length header when the response is a file object. Testing locally, including this header shows a performance improvement.

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Bug 1657445 - [wptserve] Content-Length header missing when response is a file object

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:davehunt, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5631f20805da
[wptserve] Content-Length header missing when response is a file object r=jgraham

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/25492 for changes under testing/web-platform/tests

Comment 5

[Dorel Luca [:dluca]]

Backed out changeset 5631f20805da (bug 1657445) for WPT failures. CLOSED TREE

Logs:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=315473713&repo=autoland&lineNumber=76090

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=315473209&repo=autoland&lineNumber=61904

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=315473566&repo=autoland&lineNumber=900

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=315473790&repo=autoland&lineNumber=85052

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=5631f20805dab39ddda862ce30578c41f1616e6b

Backout:
https://hg.mozilla.org/integration/autoland/rev/b3e7782cddcd2f25342050de9687efc2dec3a707

Comment 6

[Dave Hunt [:davehunt] [he/him] ⌚BST]

I'm looking into the Windows failures.

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR was closed without merging

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Dave it's quite a while since you worked on this bug. Are you still planning to finish it off?

Comment 9

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Removing myself as assignee. I wasn't ever able to replicate the Windows failures that prevented this from landing. It would be worth rebasing my (obsolete) patch and pushing to try to see if they have since resolved. If not, it will require some additional debugging.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Thanks Dave!

Kirk, given that you have this problem with your test would you may be able to have a look?

Comment 11

[Robin Steuber (she/her) [:bytesized]]

Yeah, I'll take a look and see if I can figure it out.

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Hi Kirk, I wonder if you had success in finding a solution for that issue, or isn't it blocking you anymore?

Comment 13

[Robin Steuber (she/her) [:bytesized]]

It's on my todo list to look into this. I'm hoping to have some time for it soon. I got a bit side tracked by some other work. And then I was sick all last week. Hopefully I'll have some time to look into it this week.

Comment 14

[Robin Steuber (she/her) [:bytesized]]

I rebased the attached code and took a look at the failures, but there were quite a lot of them. I tried only sending the header when the status was 200, which seemed to cut down the failures quite a bit, but there were still some pretty weird ones that I really don't understand. As I talked to people about how to potentially address them, someone mentioned that I could just set the header as a one-off by making a <filename>.headers file containing the header that I needed. That seems to have worked fine, so I think I'll probably do that instead of continuing to work towards fixing this.