1657509 - Always resolve ReadableStream's tee()'s cancel promise after the stream closes or errors

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P2)

Description

[Domenic Denicola]

See the spec bugfix at https://github.com/whatwg/streams/pull/1039 and web platform tests at https://github.com/web-platform-tests/wpt/pull/24124.

Add Comment

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Waldo: Could you take a look?

Comment 2

[Henri Sivonen (:hsivonen)]

sdetar, who is the most actively working on Streams these days?

Comment 3

[Steven DeTar [:sdetar]]

Jason, could you take a look at this streams bug?

Comment 4

[Tom S. (please needinfo tschuster)]

It almost look like we implement this: https://searchfox.org/mozilla-central/source/js/src/builtin/streams/ReadableStreamOperations.cpp#454
However we aren't passing all tests, but the problem might be something else: https://wpt.fyi/results/streams/readable-streams/tee.any.html?label=master&label=experimental&aligned&q=streams%2Freadable-streams%2Ftee

Comment 5

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1657509 - Always resolve ReadableStream's tee()'s cancel promise after the stream closes or errors. r?arai

Seems like the existing step numbers refer to a differently formated spec. I updated the numbers
where I changed something.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ab0a7a0ee384
Always resolve ReadableStream's tee()'s cancel promise after the stream closes or errors. r=arai

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/ab0a7a0ee384