1657523 - Momentary glitch when a video switches resolutions

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Markus Stange [:mstange]]

Attachment: screen recording of the glitch

This is probably a regression from bug 1653166 or from bug 1653048.

When playing a YouTube video with Auto quality, there's an inconsistent frame or two as the video changes from 720p to 1080p. It looks like the 1080p frame is displayed with the 720p transform, i.e. it renders too big.

I encountered this when watching the embedded video under "Conclusion" on https://en.chessbase.com/post/what-on-earth-is-5d-chess .

Comment 1

[Markus Stange [:mstange]]

Attachment: screenshot of the glitched frame

Comment 2

[Matt Woodrow (:mattwoodrow)]

This is a regression from https://hg.mozilla.org/mozilla-central/rev/ff35f5c6ce13

It switched videos over to use the 'computed transform' option for reference frame, and the 'scale from size' is computed in the content process.

When ImageBridge delivers a frame of a different size asynchronously, then we get the transforms wrong.

Comment 3

[Matt Woodrow (:mattwoodrow)]

Attachment: Bug 1657523 - Compute the scale from size for async image pipelines in the compositor process, so that we get the size matching the current texture. r?aosmond

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1653166

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d1268fb4ae8a
Compute the scale from size for async image pipelines in the compositor process, so that we get the size matching the current texture. r=aosmond

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/d1268fb4ae8a