1657540 - Clean up FlexboxAxisTracker

Status: RESOLVED FIXED

(Core :: Layout: Flexbox, task)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Some clean-up patches to make it easier to implement https://phabricator.services.mozilla.com/D86077

FlexboxAxisTracker::mMainAxis will be removed in this bug per suggestion in https://phabricator.services.mozilla.com/D86077#2674628

Comment 1

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1657540 Part 1 - Use IsRowOriented() to implement other methods in FlexboxAxisTracker. r=dholbert

It will be easier to change IsRowOriented()'s implementation later.

Comment 2

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1657540 Part 2 - Use IsMainAxisReversed() to implement other methods in FlexboxAxisTracker. r=dholbert

It will be easier to change IsMainAxisReversed()'s implementation later.

Depends on D86135

Comment 3

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1657540 Part 3 - Use IsCrossAxisReversed() to implement other methods in FlexboxAxisTracker. r=dholbert

It will be easier to change IsCrossAxisReversed()'s implementation later.

Depends on D86136

Comment 4

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1657540 Part 4 - Remove FlexboxAxisTracker::mMainAxis. r=dholbert

We can compute MainAxis() and CrossAxis() by using IsRowOriented().

Depends on D86137

Comment 5

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1657540 Part 5 - Remove the default branch to handle StyleFlexDirection. r=dholbert

StyleFlexDirection() is a strong enum now. It cannot have other values.

Depends on D86138

Comment 6

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Attachment: Bug 1657540 Part 6 - Remove WritingMode argument from FlexboxAxisTracker's constructor. r=dholbert

We already pass nsFlexContainerFrame into FlexboxAxisTracker, so we can
get WritingMode from the frame.

Depends on D86139

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/371d980f67cb
Part 1 - Use IsRowOriented() to implement other methods in FlexboxAxisTracker. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/fd4ec8bca53e
Part 2 - Use IsMainAxisReversed() to implement other methods in FlexboxAxisTracker. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/4a690a9ed98e
Part 3 - Use IsCrossAxisReversed() to implement other methods in FlexboxAxisTracker. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/e30dd8dc3f51
Part 4 - Remove FlexboxAxisTracker::mMainAxis. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/9093bbbc3a6b
Part 5 - Remove the default branch to handle StyleFlexDirection. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/a0753879ef1f
Part 6 - Remove WritingMode argument from FlexboxAxisTracker's constructor. r=dholbert

Comment 8

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/371d980f67cb
https://hg.mozilla.org/mozilla-central/rev/fd4ec8bca53e
https://hg.mozilla.org/mozilla-central/rev/4a690a9ed98e
https://hg.mozilla.org/mozilla-central/rev/e30dd8dc3f51
https://hg.mozilla.org/mozilla-central/rev/9093bbbc3a6b
https://hg.mozilla.org/mozilla-central/rev/a0753879ef1f