Closed Bug 1657540 Opened 1 year ago Closed 1 year ago

Clean up FlexboxAxisTracker

Categories

(Core :: Layout: Flexbox, task)

task

Tracking

()

RESOLVED FIXED
81 Branch
Tracking Status
firefox81 --- fixed

People

(Reporter: TYLin, Assigned: TYLin)

References

Details

Attachments

(6 files)

Some clean-up patches to make it easier to implement https://phabricator.services.mozilla.com/D86077

FlexboxAxisTracker::mMainAxis will be removed in this bug per suggestion in https://phabricator.services.mozilla.com/D86077#2674628

It will be easier to change IsRowOriented()'s implementation later.

It will be easier to change IsMainAxisReversed()'s implementation later.

Depends on D86135

It will be easier to change IsCrossAxisReversed()'s implementation later.

Depends on D86136

We can compute MainAxis() and CrossAxis() by using IsRowOriented().

Depends on D86137

StyleFlexDirection() is a strong enum now. It cannot have other values.

Depends on D86138

We already pass nsFlexContainerFrame into FlexboxAxisTracker, so we can
get WritingMode from the frame.

Depends on D86139

Pushed by aethanyc@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/371d980f67cb
Part 1 - Use IsRowOriented() to implement other methods in FlexboxAxisTracker. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/fd4ec8bca53e
Part 2 - Use IsMainAxisReversed() to implement other methods in FlexboxAxisTracker. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/4a690a9ed98e
Part 3 - Use IsCrossAxisReversed() to implement other methods in FlexboxAxisTracker. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/e30dd8dc3f51
Part 4 - Remove FlexboxAxisTracker::mMainAxis. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/9093bbbc3a6b
Part 5 - Remove the default branch to handle StyleFlexDirection. r=dholbert
https://hg.mozilla.org/integration/autoland/rev/a0753879ef1f
Part 6 - Remove WritingMode argument from FlexboxAxisTracker's constructor. r=dholbert
Blocks: 1042151
You need to log in before you can comment on or make changes to this bug.