1657555 - 8.95% basic_compositor_video (macosx1014-64-shippable) regression on push 4558b3cfd6fe49647780a0ec86dfa97f0dd3adcb (Tue August 4 2020)

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Alexandru Ionescu (needinfo me) [:alexandrui]]

Perfherder has detected a talos performance regression from push 4558b3cfd6fe49647780a0ec86dfa97f0dd3adcb. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

9% basic_compositor_video macosx1014-64-shippable opt e10s stylo 5.11 -> 5.57

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) will be backed out in accordance with our regression policy.

For more information on performance sheriffing please see our FAQ.

Comment 1

[Alexandru Ionescu (needinfo me) [:alexandrui]]

Matt, this is a regression caused by one of Bug 1653048, Bug 1653166 or Bug 1653409. Their patches landed in the same revision. Are you able to tell which patch might be causing the regression?

Comment 2

[Alexandru Ionescu (needinfo me) [:alexandrui]]

Nevermind, Bug 1653409 was revealed by the bisection to be the culprit.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1653409

Comment 4

[Markus Stange [:mstange]]

The patch from bug 1657107 makes it so that we only use IOSurface for software-decoded video if we're compositing with WebRender. So it should make the BasicCompositor configuration go back to the old path and fix this bug.