Open Bug 1657567 Opened 4 years ago Updated 4 years ago

Inspector resets horizontal scroll position when you click on the element anywhere within the inspector tool

Categories

(DevTools :: Inspector, defect, P3)

Product:
DevTools
Component:
Inspector
Version:
Firefox 81
Type:
defect

Tracking

(Not tracked)

People

(Reporter: mozilla-crowdicity.wadmol, Unassigned)

Details

Attachments

(2 files, 1 obsolete file)

automatic-focus-onclick.mp4
2.85 MB, video/mp4
Details
do-not-move-focus-on-subsequent-clicks.mp4
859.55 KB, video/mp4
Details

What were you doing?

  1. Open this example fiddle
  2. Open Inspector tool and select image in the preview
  3. Try to select data-some-attribute attribute for editing

Note: You might have to resize browser window to see horizontal scrollbar

What happened?

Inspector scrolls back to <img> tag beginning which makes it impossible to edit attributes using double-click or right-click

What should have happened?

Scroll position should not change or add preference for wrapping

The severity field is not set for this bug.
:gl, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(gl)

This is a speculative fix. Open to suggestions if there's a better approach.

When clicking a node in the Markup view, the MarkupContainer for that node will shift focus to the first editor for that node's attributes. This is good for accessibility and for keyboard navigation.
But when the Markup view is narrow, the effect is shifting the horizontal scroll in order to bring the editor into view.

As a mouse user, if I want to double click a node attribute to edit it, the focus shifts as soon as I click first.
This is particulalrly annoying for attributes at the far end of the node. I can't edit the attribute because it shifts away as the focus moves to the first editor.

The proposed fix is to keep the original behavior on first click on a MarkupContainer (focus the first editor, shift scroll if the viewport is too narrow).
But on second click, i.e. the MarkupContainer is already selected, skip moving focus and allow the user to edit node attributes.

Assignee: nobody → rcaliman

Thanks for reporting this, Ashutosh!

Indeed, on narrow viewports it's almost impossible to edit attributes as the horizontal scroll shifts.
One workaround is to tab navigate through the node attributes until you get to the desired one and change it. Not ideal, I know.

There is a good reason for the horizontal shift: it's to focus the first editor of the node and enable keyboard navigation. But I agree it's annoying not to be able to use the mouse to double click an attribute and edit it.

I submitted a speculative fix. I don't know about side-effects on yet.

Severity: -- → S3
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(gl)
Priority: -- → P3

Video of current behavior.

On click, focus moves automatically to the first attribute editor shifting the horizontal focus if the viewport is narrow. Workaround: tab navigate through the attributes

Video of proposed fix

Do not shift focus on second click if the element is already selected. Allow mouse users to double click on any attribute to edit it. Caveat: need to move scroll manually if attribute is not fully in viewport.

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:rcaliman, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(rcaliman)
Pushed by rcaliman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/33ba7de82d52
Prevent shifting focus within a markup container when already selected. r=gl

Backed out changeset 33ba7de82d52 (bug 1657567) for browser_markup failures.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&searchStr=linux%2C18.04%2Cx64%2Cdebug%2Cmochitests%2Ctest-linux1804-64%2Fdebug-mochitest-devtools-chrome-e10s%2Cdt10&tochange=19bc84a9ed83efac55c260d5437c3426eeb36b49&fromchange=8d71aed8e8c2bccbfd542cd849d3af78b83f2128&selectedTaskRun=THgmef7ATBW_u9JEf-qpVg.0

Backout link: https://hg.mozilla.org/integration/autoland/rev/8638463769b4d22cc020b6aa00b0828bf1733935

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=317732094&repo=autoland&lineNumber=5205

[task 2020-10-06T10:02:08.250Z] 10:02:08     INFO - TEST-START | devtools/client/inspector/markup/test/browser_markup_dragdrop_escapeKeyPress.js
[task 2020-10-06T10:02:08.270Z] 10:02:08     INFO - Entering test bound 
[task 2020-10-06T10:02:08.272Z] 10:02:08     INFO - Adding a new tab with URL: http://example.com/browser/devtools/client/inspector/markup/test/doc_markup_dragdrop.html
[task 2020-10-06T10:02:08.293Z] 10:02:08     INFO - GECKO(1487) | [Child 1797: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0x7f7feefc1400 == 2 [pid = 1797] [id = 12]
[task 2020-10-06T10:02:08.294Z] 10:02:08     INFO - GECKO(1487) | [Child 1797: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 4 (0x7f800cc93520) [pid = 1797] [serial = 37] [outer = (nil)]
[task 2020-10-06T10:02:08.297Z] 10:02:08     INFO - GECKO(1487) | [Child 1797: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 5 (0x7f7fef567800) [pid = 1797] [serial = 38] [outer = 0x7f800cc93520]
[task 2020-10-06T10:02:08.418Z] 10:02:08     INFO - GECKO(1487) | [Child 1797: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 6 (0x7f7ff05b7000) [pid = 1797] [serial = 39] [outer = 0x7f800cc93520]
[task 2020-10-06T10:02:08.507Z] 10:02:08     INFO - Tab added and finished loading
[task 2020-10-06T10:02:08.510Z] 10:02:08     INFO - Opening the inspector
[task 2020-10-06T10:02:08.510Z] 10:02:08     INFO - Opening the toolbox
[task 2020-10-06T10:02:08.571Z] 10:02:08     INFO - GECKO(1487) | [Parent 1487: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x7f6d08b80800 == 7 [pid = 1487] [id = 72] [url = chrome://devtools/content/inspector/markup/markup.xhtml]
[task 2020-10-06T10:02:08.599Z] 10:02:08     INFO - GECKO(1487) | [Parent 1487: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0x7f6ce3b29000 == 8 [pid = 1487] [id = 73]
[task 2020-10-06T10:02:08.599Z] 10:02:08     INFO - GECKO(1487) | [Parent 1487: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 24 (0x7f6d00f21430) [pid = 1487] [serial = 170] [outer = (nil)]
[task 2020-10-06T10:02:08.606Z] 10:02:08     INFO - GECKO(1487) | [Parent 1487: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 25 (0x7f6d0056b000) [pid = 1487] [serial = 171] [outer = 0x7f6d00f21430]
[task 2020-10-06T10:02:08.631Z] 10:02:08     INFO - GECKO(1487) | [Child 1797, Main Thread] WARNING: Scrolled rect smaller than scrollport?: file /builds/worker/checkouts/gecko/layout/generic/nsGfxScrollFrame.cpp, line 6898
[task 2020-10-06T10:02:08.674Z] 10:02:08     INFO - GECKO(1487) | [Parent 1487: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 26 (0x7f6d00576c00) [pid = 1487] [serial = 172] [outer = 0x7f6d00f21430]
[task 2020-10-06T10:02:08.763Z] 10:02:08     INFO - GECKO(1487) | [Parent 1487, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005 (NS_ERROR_FAILURE): file /builds/worker/checkouts/gecko/dom/base/nsContentUtils.cpp, line 3779
[task 2020-10-06T10:02:08.851Z] 10:02:08     INFO - GECKO(1487) | [Parent 1487: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0x7f6d0056c800 == 9 [pid = 1487] [id = 74]
[task 2020-10-06T10:02:08.852Z] 10:02:08     INFO - GECKO(1487) | [Parent 1487: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 27 (0x7f6d00f222b0) [pid = 1487] [serial = 173] [outer = (nil)]
[task 2020-10-06T10:02:08.853Z] 10:02:08     INFO - GECKO(1487) | [Parent 1487, Main Thread] WARNING: 'NS_FAILED(targetPrincipal->GetAsciiOrigin(targetOrigin))', file /builds/worker/checkouts/gecko/toolkit/components/antitracking/AntiTrackingUtils.cpp, line 347
[task 2020-10-06T10:02:08.854Z] 10:02:08     INFO - GECKO(1487) | [Parent 1487: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 28 (0x7f6d00d0bc00) [pid = 1487] [serial = 174] [outer = 0x7f6d00f222b0]
[task 2020-10-06T10:02:09.571Z] 10:02:09     INFO - GECKO(1487) | [Parent 1487: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0x7f6d08b79c00 == 10 [pid = 1487] [id = 75]
[task 2020-10-06T10:02:09.573Z] 10:02:09     INFO - GECKO(1487) | [Parent 1487: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 29 (0x7f6d00f24e30) [pid = 1487] [serial = 175] [outer = (nil)]
[task 2020-10-06T10:02:09.574Z] 10:02:09     INFO - GECKO(1487) | [Parent 1487, Main Thread] WARNING: 'NS_FAILED(targetPrincipal->GetAsciiOrigin(targetOrigin))', file /builds/worker/checkouts/gecko/toolkit/components/antitracking/AntiTrackingUtils.cpp, line 347
[task 2020-10-06T10:02:09.575Z] 10:02:09     INFO - GECKO(1487) | [Parent 1487: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 30 (0x7f6d0ebcf800) [pid = 1487] [serial = 176] [outer = 0x7f6d00f24e30]
[task 2020-10-06T10:02:09.694Z] 10:02:09     INFO - GECKO(1487) | console.log: "[DISPATCH] action type:" "UPDATE_GRIDS"
[task 2020-10-06T10:02:09.850Z] 10:02:09     INFO - GECKO(1487) | console.log: "[DISPATCH] action type:" "CLEAR_FLEXBOX"
[task 2020-10-06T10:02:10.042Z] 10:02:10     INFO - GECKO(1487) | console.log: "[DISPATCH] action type:" "UPDATE_GRIDS"
[task 2020-10-06T10:02:10.058Z] 10:02:10     INFO - GECKO(1487) | console.log: "[DISPATCH] action type:" "CLEAR_FLEXBOX"
[task 2020-10-06T10:02:10.060Z] 10:02:10     INFO - GECKO(1487) | console.log: "[DISPATCH] action type:" "UPDATE_OFFSET_PARENT"
[task 2020-10-06T10:02:10.080Z] 10:02:10     INFO - GECKO(1487) | console.log: "[DISPATCH] action type:" "UPDATE_LAYOUT"
[task 2020-10-06T10:02:10.096Z] 10:02:10     INFO - Toolbox opened and focused
[task 2020-10-06T10:02:10.097Z] 10:02:10     INFO - Get a test container
[task 2020-10-06T10:02:10.098Z] 10:02:10     INFO - Selecting the node for '#test'
[task 2020-10-06T10:02:10.221Z] 10:02:10     INFO - GECKO(1487) | [Parent 1487, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, nullptr) failed with result 0x804B000A (NS_ERROR_MALFORMED_URI): file /builds/worker/checkouts/gecko/extensions/permissions/Permission.cpp, line 46
[task 2020-10-06T10:02:10.222Z] 10:02:10     INFO - GECKO(1487) | [Parent 1487, Main Thread] WARNING: NS_ENSURE_TRUE(principal) failed: file /builds/worker/checkouts/gecko/extensions/permissions/Permission.cpp, line 58
[task 2020-10-06T10:02:10.241Z] 10:02:10     INFO - Getting the markup-container for node #test
[task 2020-10-06T10:02:10.282Z] 10:02:10     INFO - GECKO(1487) | console.log: "[DISPATCH] action type:" "CLEAR_FLEXBOX"
[task 2020-10-06T10:02:10.298Z] 10:02:10     INFO - TEST-PASS | devtools/client/inspector/markup/test/browser_markup_dragdrop_escapeKeyPress.js | Found markup-container for selector: #test - 
[task 2020-10-06T10:02:10.298Z] 10:02:10     INFO - Simulate a drag/drop on this container
[task 2020-10-06T10:02:10.298Z] 10:02:10     INFO - Getting the markup-container for node #test
[task 2020-10-06T10:02:10.318Z] 10:02:10     INFO - TEST-PASS | devtools/client/inspector/markup/test/browser_markup_dragdrop_escapeKeyPress.js | Found markup-container for selector: #test - 
[task 2020-10-06T10:02:10.322Z] 10:02:10     INFO - Simulate mouseDown on element #test
[task 2020-10-06T10:02:10.325Z] 10:02:10     INFO - Simulate mouseMove on element #test
[task 2020-10-06T10:02:10.341Z] 10:02:10     INFO - TEST-PASS | devtools/client/inspector/markup/test/browser_markup_dragdrop_escapeKeyPress.js | The container is being dragged - 
[task 2020-10-06T10:02:10.345Z] 10:02:10     INFO - TEST-PASS | devtools/client/inspector/markup/test/browser_markup_dragdrop_escapeKeyPress.js | The dragging css class was added - 
[task 2020-10-06T10:02:10.345Z] 10:02:10     INFO - Simulate ESCAPE keypress
[task 2020-10-06T10:02:10.353Z] 10:02:10     INFO - GECKO(1487) | [Parent 1487: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0x7f6d13fc8400 == 11 [pid = 1487] [id = 76]
[task 2020-10-06T10:02:10.353Z] 10:02:10     INFO - GECKO(1487) | [Parent 1487: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 31 (0x7f6d053a1a40) [pid = 1487] [serial = 177] [outer = (nil)]
[task 2020-10-06T10:02:10.354Z] 10:02:10     INFO - GECKO(1487) | [Parent 1487, Main Thread] WARNING: 'NS_FAILED(targetPrincipal->GetAsciiOrigin(targetOrigin))', file /builds/worker/checkouts/gecko/toolkit/components/antitracking/AntiTrackingUtils.cpp, line 347
[task 2020-10-06T10:02:10.354Z] 10:02:10     INFO - GECKO(1487) | [Parent 1487: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 32 (0x7f6d13fc5800) [pid = 1487] [serial = 178] [outer = 0x7f6d053a1a40]
[task 2020-10-06T10:02:10.374Z] 10:02:10     INFO - TEST-INFO | started process screentopng
[task 2020-10-06T10:02:10.643Z] 10:02:10     INFO - TEST-INFO | screentopng: exit 0
[task 2020-10-06T10:02:10.647Z] 10:02:10     INFO - TEST-UNEXPECTED-FAIL | devtools/client/inspector/markup/test/browser_markup_dragdrop_escapeKeyPress.js | The dragging has stopped - 
[task 2020-10-06T10:02:10.648Z] 10:02:10     INFO - Stack trace:
[task 2020-10-06T10:02:10.649Z] 10:02:10     INFO - chrome://mochikit/content/browser-test.js:test_ok:1304
[task 2020-10-06T10:02:10.649Z] 10:02:10     INFO - chrome://mochitests/content/browser/devtools/client/inspector/markup/test/browser_markup_dragdrop_escapeKeyPress.js:null:33
[task 2020-10-06T10:02:10.650Z] 10:02:10     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1069
[task 2020-10-06T10:02:10.650Z] 10:02:10     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1109
[task 2020-10-06T10:02:10.650Z] 10:02:10     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:932
[task 2020-10-06T10:02:10.651Z] 10:02:10     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:1037
[task 2020-10-06T10:02:10.651Z] 10:02:10     INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-10-06T10:02:10.658Z] 10:02:10     INFO - TEST-UNEXPECTED-FAIL | devtools/client/inspector/markup/test/browser_markup_dragdrop_escapeKeyPress.js | The dragging css class was removed - 
[task 2020-10-06T10:02:10.658Z] 10:02:10     INFO - Stack trace:
[task 2020-10-06T10:02:10.659Z] 10:02:10     INFO - chrome://mochikit/content/browser-test.js:test_ok:1304
[task 2020-10-06T10:02:10.663Z] 10:02:10     INFO - chrome://mochitests/content/browser/devtools/client/inspector/markup/test/browser_markup_dragdrop_escapeKeyPress.js:null:34
[task 2020-10-06T10:02:10.663Z] 10:02:10     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1069
[task 2020-10-06T10:02:10.663Z] 10:02:10     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1109
[task 2020-10-06T10:02:10.663Z] 10:02:10     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:932
[task 2020-10-06T10:02:10.664Z] 10:02:10     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:1037
[task 2020-10-06T10:02:10.664Z] 10:02:10     INFO - Leaving test bound 
[task 2020-10-06T10:02:10.664Z] 10:02:10     INFO - GECKO(1487) | console.log: "[DISPATCH] action type:" "UPDATE_OFFSET_PARENT"
[task 2020-10-06T10:02:10.664Z] 10:02:10     INFO - GECKO(1487) | console.log: "[DISPATCH] action type:" "UPDATE_LAYOUT"
[task 2020-10-06T10:02:11.257Z] 10:02:11     INFO - GECKO(1487) | [Child 1797: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x7f7feefb7000 == 1 [pid = 1797] [id = 11] [url = http://example.com/browser/devtools/client/inspector/markup/test/doc_markup_dragdrop.html]
[task 2020-10-06T10:02:11.374Z] 10:02:11     INFO - GECKO(1487) | [Child 1797: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 5 (0x7f800cc93180) [pid = 1797] [serial = 34] [outer = (nil)] [url = http://example.com/browser/devtools/client/inspector/markup/test/doc_markup_dragdrop.html]
[task 2020-10-06T10:02:11.757Z] 10:02:11     INFO - GECKO(1487) | [Child 1638: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 4 (0x7ff00edf2000) [pid = 1638] [serial = 39] [outer = (nil)] [url = about:blank]
[task 2020-10-06T10:02:11.778Z] 10:02:11     INFO - GECKO(1487) | [Child 1638: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x7ff00edef400 == 0 [pid = 1638] [id = 17] [url = about:blank]
[task 2020-10-06T10:02:11.874Z] 10:02:11     INFO - GECKO(1487) | [Child 1638: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 3 (0x7ff02c693180) [pid = 1638] [serial = 40] [outer = (nil)] [url = http://example.com/browser/devtools/client/inspector/markup/test/doc_markup_dragdrop.html]
[task 2020-10-06T10:02:12.051Z] 10:02:12     INFO - GECKO(1487) | [Parent 1487: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 31 (0x7f6ce3b33800) [pid = 1487] [serial = 164] [outer = (nil)] [url = about:blank]
[task 2020-10-06T10:02:12.067Z] 10:02:12     INFO - GECKO(1487) | [Parent 1487: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x7f6d0056ec00 == 10 [pid = 1487] [id = 71] [url = chrome://devtools/content/inspector/index.xhtml]
[task 2020-10-06T10:02:12.131Z] 10:02:12     INFO - Removing tab.
[task 2020-10-06T10:02:12.132Z] 10:02:12     INFO - Waiting for event: 'TabClose' on [object XULElement].
[task 2020-10-06T10:02:12.151Z] 10:02:12     INFO - Got event: 'TabClose' on [object XULElement].
[task 2020-10-06T10:02:12.172Z] 10:02:12     INFO - GECKO(1487) | [Parent 1487, Main Thread] WARNING: '!inner', file /builds/worker/checkouts/gecko/dom/ipc/jsactor/JSWindowActorProtocol.cpp, line 172
[task 2020-10-06T10:02:12.173Z] 10:02:12     INFO - GECKO(1487) | [Parent 1487, Main Thread] WARNING: '!inner', file /builds/worker/checkouts/gecko/dom/ipc/jsactor/JSWindowActorProtocol.cpp, line 172
[task 2020-10-06T10:02:12.180Z] 10:02:12     INFO - Tab removed and finished closing
[task 2020-10-06T10:02:12.201Z] 10:02:12     INFO - GECKO(1487) | [Parent 1487, Main Thread] WARNING: 'aOwner->IsDiscarded()', file /builds/worker/workspace/obj-build/dist/include/mozilla/dom/SyncedContextInlines.h, line 36
[task 2020-10-06T10:02:12.208Z] 10:02:12     INFO - GECKO(1487) | [Parent 1487, DOM Worker] WARNING: '!mWorkerPrivate->AddWorkerRef(this, aStatus)', file /builds/worker/checkouts/gecko/dom/workers/WorkerRef.cpp, line 80
[task 2020-10-06T10:02:12.233Z] 10:02:12     INFO - GECKO(1487) | [Child 1745: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 0x7f329b7c6400 == 1 [pid = 1745] [id = 14] [url = about:blank]
[task 2020-10-06T10:02:12.309Z] 10:02:12     INFO - TEST-PASS | devtools/client/inspector/markup/test/browser_markup_dragdrop_escapeKeyPress.js | The main process DevToolsServer has no pending connection when the test ends - 
[task 2020-10-06T10:02:12.333Z] 10:02:12     INFO - GECKO(1487) | MEMORY STAT | vsize 3398MB | residentFast 443MB | heapAllocated 143MB
[task 2020-10-06T10:02:12.334Z] 10:02:12     INFO - TEST-OK | devtools/client/inspector/markup/test/browser_markup_dragdrop_escapeKeyPress.js | took 4088ms
[task 2020-10-06T10:02:12.349Z] 10:02:12     INFO - GECKO(1487) | [Child 1638: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 0x7ff00edef000 == 1 [pid = 1638] [id = 18]
[task 2020-10-06T10:02:12.349Z] 10:02:12     INFO - GECKO(1487) | [Child 1638: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 4 (0x7ff02c693180) [pid = 1638] [serial = 45] [outer = (nil)]
[task 2020-10-06T10:02:12.351Z] 10:02:12     INFO - GECKO(1487) | [Child 1638: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 5 (0x7ff00edf0400) [pid = 1638] [serial = 46] [outer = 0x7ff02c693180]
[task 2020-10-06T10:02:12.378Z] 10:02:12     INFO - GECKO(1487) | [Parent 1487, DOM Worker] WARNING: Extra shutdown CC: 'i < NORMAL_SHUTDOWN_COLLECTIONS', file /builds/worker/checkouts/gecko/xpcom/base/nsCycleCollector.cpp, line 3359
[task 2020-10-06T10:02:12.399Z] 10:02:12     INFO - GECKO(1487) | [Child 1745: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 5 (0x7f32b8d936f0) [pid = 1745] [serial = 30] [outer = (nil)] [url = http://example.com/browser/devtools/client/inspector/markup/test/doc_markup_dragdrop.html]
[task 2020-10-06T10:02:12.399Z] 10:02:12     INFO - GECKO(1487) | [Child 1745: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 4 (0x7f32b8d93180) [pid = 1745] [serial = 33] [outer = (nil)] [url = about:blank]
[task 2020-10-06T10:02:12.415Z] 10:02:12     INFO - checking window state

Rats! I'll address the failing test and resend for landing!

Flags: needinfo?(rcaliman)

ni me so it stays on my radar

Flags: needinfo?(rcaliman)
Attachment #9171405 - Attachment is obsolete: true
Assignee: rcaliman → nobody
Flags: needinfo?(rcaliman)
OS: Linux → All
Hardware: x86_64 → All
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: