Closed Bug 1657583 Opened 6 months ago Closed 6 months ago

Simplify TestSitePermission within nsHTTPSOnlyUtils

Categories

(Core :: DOM: Security, task, P1)

task

Tracking

()

RESOLVED FIXED
81 Branch
Tracking Status
firefox81 --- fixed

People

(Reporter: ckerschb, Assigned: ckerschb)

References

(Blocks 1 open bug)

Details

(Whiteboard: [domsecurity-active])

Attachments

(1 file)

No description provided.
Pushed by btara@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5a2241b01c82
Simplify TestSitePermission within nsHTTPSOnlyUtils r=necko-reviewers,JulianWels,dragana

Backed out changeset 5a2241b01c82 (bug 1657583) for DocumentLoadListener.cpp related bustage

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&fromchange=5a2cf7ed707926734437af6e31c9254e5476d5b4&searchStr=build&tochange=f26081845d64b1050aa3236c8012980ab0f28ef2&selectedTaskRun=AlZw59iAQj2KY4kW27Ia7w.0

Backout link: https://hg.mozilla.org/integration/autoland/rev/f26081845d64b1050aa3236c8012980ab0f28ef2

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=312377810&repo=autoland&lineNumber=38894

[task 2020-08-07T11:55:38.117Z] 11:55:38     INFO -  make[4]: Entering directory '/builds/worker/workspace/obj-build/netwerk/ipc'
[task 2020-08-07T11:55:38.121Z] 11:55:38     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang++ -std=gnu++17 --target=x86_64-linux-android -o Unified_cpp_netwerk_ipc0.o -c  -I/builds/worker/workspace/obj-build/dist/stl_wrappers -I/builds/worker/workspace/obj-build/dist/system_wrappers -include /builds/worker/checkouts/gecko/config/gcc_hidden.h -fstack-protector-strong -DNDEBUG=1 -DTRIMMED=1 -DOS_POSIX=1 -DOS_LINUX=1 -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/netwerk/ipc -I/builds/worker/workspace/obj-build/netwerk/ipc -I/builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders -I/builds/worker/checkouts/gecko/ipc/chromium/src -I/builds/worker/checkouts/gecko/ipc/glue -I/builds/worker/checkouts/gecko/caps -I/builds/worker/checkouts/gecko/dom/base -I/builds/worker/checkouts/gecko/media/mtransport -I/builds/worker/checkouts/gecko/media/webrtc -I/builds/worker/checkouts/gecko/modules/libjar -I/builds/worker/checkouts/gecko/netwerk/base -I/builds/worker/checkouts/gecko/netwerk/protocol/http -I/builds/worker/checkouts/gecko/security/manager/ssl -I/builds/worker/checkouts/gecko/xpcom/threads -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h -Qunused-arguments -isystem /builds/worker/fetches/android-ndk/sysroot/usr/include/x86_64-linux-android -isystem /builds/worker/fetches/android-ndk/sysroot/usr/include -gcc-toolchain /builds/worker/fetches/android-ndk/toolchains/x86_64-4.9/prebuilt/linux-x86_64 -D__ANDROID_API__=21 -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Wunused-function -Wunused-variable -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-error=tautological-type-limit-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=return-std-move -Wno-error=atomic-alignment -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Werror=implicit-function-declaration -Wno-unknown-warning-option -fno-sized-deallocation -fno-aligned-new -fno-short-enums -fno-exceptions -stdlib=libstdc++ -I/builds/worker/fetches/android-ndk/sources/cxx-stl/llvm-libc++/include -I/builds/worker/fetches/android-ndk/sources/android/support/include -I/builds/worker/fetches/android-ndk/sources/cxx-stl/llvm-libc++abi/include -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pipe -g -Xclang -load -Xclang /builds/worker/workspace/obj-build/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O2 -fno-omit-frame-pointer -funwind-tables -Werror -fexperimental-new-pass-manager  -MD -MP -MF .deps/Unified_cpp_netwerk_ipc0.o.pp   Unified_cpp_netwerk_ipc0.cpp
[task 2020-08-07T11:55:38.121Z] 11:55:38     INFO -  In file included from Unified_cpp_netwerk_ipc0.cpp:38:
[task 2020-08-07T11:55:38.121Z] 11:55:38    ERROR -  /builds/worker/checkouts/gecko/netwerk/ipc/DocumentLoadListener.cpp:2338:7: error: use of undeclared identifier 'bc'
[task 2020-08-07T11:55:38.122Z] 11:55:38     INFO -        bc ? bc->GetParentProcessWidgetContaining() : nullptr;
[task 2020-08-07T11:55:38.122Z] 11:55:38     INFO -        ^
[task 2020-08-07T11:55:38.122Z] 11:55:38    ERROR -  /builds/worker/checkouts/gecko/netwerk/ipc/DocumentLoadListener.cpp:2338:12: error: use of undeclared identifier 'bc'
[task 2020-08-07T11:55:38.122Z] 11:55:38     INFO -        bc ? bc->GetParentProcessWidgetContaining() : nullptr;
[task 2020-08-07T11:55:38.122Z] 11:55:38     INFO -             ^
[task 2020-08-07T11:55:38.122Z] 11:55:38    ERROR -  /builds/worker/checkouts/gecko/netwerk/ipc/DocumentLoadListener.cpp:2345:53: error: use of undeclared identifier 'bc'
[task 2020-08-07T11:55:38.122Z] 11:55:38     INFO -                                      nullptr, false, bc->IsTopContent());
[task 2020-08-07T11:55:38.122Z] 11:55:38     INFO -                                                      ^
[task 2020-08-07T11:55:38.122Z] 11:55:38     INFO -  3 errors generated.
[task 2020-08-07T11:55:38.122Z] 11:55:38    ERROR -  make[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:718: Unified_cpp_netwerk_ipc0.o] Error 1
[task 2020-08-07T11:55:38.122Z] 11:55:38     INFO -  make[4]: Leaving directory '/builds/worker/workspace/obj-build/netwerk/ipc'
[task 2020-08-07T11:55:38.122Z] 11:55:38    ERROR -  make[3]: *** [/builds/worker/checkouts/gecko/config/recurse.mk:72: netwerk/ipc/target-objects] Error 2
[task 2020-08-07T11:55:38.122Z] 11:55:38     INFO -  make[3]: *** Waiting for unfinished jobs....
Flags: needinfo?(ckerschb)

(In reply to Bogdan Tara[:bogdan_tara | bogdant] from comment #3)

Backed out changeset 5a2241b01c82 (bug 1657583) for DocumentLoadListener.cpp related bustage

Huh, how come? Sorry - I'll take a look right away.

Flags: needinfo?(ckerschb)
Pushed by btara@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c20c383af4db
Simplify TestSitePermission within nsHTTPSOnlyUtils r=necko-reviewers,JulianWels,dragana

Backed out changeset c20c383af4db (bug 1657583) for http related failures

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&searchStr=mochitest-browser-chrome&fromchange=874993c81bcb9bd8950b42812c92f4a1331334bb&tochange=a8087a6f012c5ac61756aceed9b0c97b7a11493c&selectedTaskRun=ChAaXcPqRyii8vy14__Ijg.0

Backout link: https://hg.mozilla.org/integration/autoland/rev/a8087a6f012c5ac61756aceed9b0c97b7a11493c

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=312392360&repo=autoland&lineNumber=4485

[task 2020-08-07T13:41:12.813Z] 13:41:12     INFO - TEST-START | toolkit/components/httpsonlyerror/tests/browser/browser_exception.js
[task 2020-08-07T13:41:13.285Z] 13:41:13     INFO - TEST-INFO | started process screencapture
[task 2020-08-07T13:41:13.425Z] 13:41:13     INFO - TEST-INFO | screencapture: exit 0
[task 2020-08-07T13:41:13.426Z] 13:41:13     INFO - Buffered messages logged at 13:41:12
[task 2020-08-07T13:41:13.426Z] 13:41:13     INFO - Entering test bound 
[task 2020-08-07T13:41:13.426Z] 13:41:13     INFO - Leaving test bound 
[task 2020-08-07T13:41:13.426Z] 13:41:13     INFO - Entering test bound 
[task 2020-08-07T13:41:13.427Z] 13:41:13     INFO - Console message: [JavaScript Warning: "HTTPS-Only Mode: Upgrading insecure request “http://example.com/browser/toolkit/components/httpsonlyerror/tests/browser/file_upgrade_insecure_server.sjs?queryresult=http://example.com/browser/toolkit/components/httpsonlyerror/tests/browser/” to use “https”." {file: "http://example.com/browser/toolkit/components/httpsonlyerror/tests/browser/file_upgrade_insecure_server.sjs?queryresult=http://example.com/browser/toolkit/components/httpsonlyerror/tests/browser/" line: 0}]
[task 2020-08-07T13:41:13.427Z] 13:41:13     INFO - Console message: [JavaScript Warning: "HTTPS-Only Mode: Upgrading insecure request “http://supports-insecure.expired.example.com/browser/toolkit/components/httpsonlyerror/tests/browser/file_upgrade_insecure_server.sjs?content” to use “https”."]
[task 2020-08-07T13:41:13.427Z] 13:41:13     INFO - Console message: [JavaScript Error: "HTTPS-Only Mode: Upgrading insecure request “https://supports-insecure.expired.example.com/browser/toolkit/components/httpsonlyerror/tests/browser/file_upgrade_insecure_server.sjs?content” failed. (M21-C12276)"]
[task 2020-08-07T13:41:13.427Z] 13:41:13     INFO - Buffered messages logged at 13:41:13
[task 2020-08-07T13:41:13.427Z] 13:41:13     INFO - Loading and waiting for the error page
[task 2020-08-07T13:41:13.428Z] 13:41:13     INFO - TEST-PASS | toolkit/components/httpsonlyerror/tests/browser/browser_exception.js | openInsecureButton should exist. - true == true - 
[task 2020-08-07T13:41:13.430Z] 13:41:13     INFO - Console message: [JavaScript Error: "HTTPS-Only Mode: Not upgrading insecure request “http://supports-insecure.expired.example.com/browser/toolkit/components/httpsonlyerror/tests/browser/file_upgrade_insecure_server.sjs?content” because it is exempt."]
[task 2020-08-07T13:41:13.431Z] 13:41:13     INFO - Console message: [JavaScript Error: "HTTPS-Only Mode: Not upgrading insecure request “http://example.com/browser/toolkit/components/httpsonlyerror/tests/browser/file_upgrade_insecure_server.sjs?img” because it is exempt." {file: "http://example.com/browser/toolkit/components/httpsonlyerror/tests/browser/file_upgrade_insecure_server.sjs?img" line: 0}]
[task 2020-08-07T13:41:13.431Z] 13:41:13     INFO - Console message: [JavaScript Error: "HTTPS-Only Mode: Not upgrading insecure request “http://example.com/browser/toolkit/components/httpsonlyerror/tests/browser/file_upgrade_insecure_server.sjs?xhr” because it is exempt." {file: "http://supports-insecure.expired.example.com/browser/toolkit/components/httpsonlyerror/tests/browser/file_upgrade_insecure_server.sjs?content" line: 12}]
[task 2020-08-07T13:41:13.431Z] 13:41:13     INFO - Console message: [JavaScript Warning: "HTTPS-Only Mode: Upgrading insecure request “http://example.com/browser/toolkit/components/httpsonlyerror/tests/browser/file_upgrade_insecure_server.sjs?iframe” to use “https”." {file: "http://example.com/browser/toolkit/components/httpsonlyerror/tests/browser/file_upgrade_insecure_server.sjs?iframe" line: 0}]
[task 2020-08-07T13:41:13.431Z] 13:41:13     INFO - Console message: [JavaScript Error: "HTTPS-Only Mode: Not upgrading insecure request “http://example.com/browser/toolkit/components/httpsonlyerror/tests/browser/file_upgrade_insecure_server.sjs?img” because it is exempt." {file: "http://example.com/browser/toolkit/components/httpsonlyerror/tests/browser/file_upgrade_insecure_server.sjs?img" line: 0}]
[task 2020-08-07T13:41:13.431Z] 13:41:13     INFO - Console message: [JavaScript Error: "HTTPS-Only Mode: Not upgrading insecure request “http://example.com/browser/toolkit/components/httpsonlyerror/tests/browser/file_upgrade_insecure_server.sjs?xhr” because it is exempt." {file: "http://example.com/browser/toolkit/components/httpsonlyerror/tests/browser/file_upgrade_insecure_server.sjs?xhr" line: 0}]
[task 2020-08-07T13:41:13.435Z] 13:41:13     INFO - Console message: [JavaScript Error: "Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at http://example.com/browser/toolkit/components/httpsonlyerror/tests/browser/file_upgrade_insecure_server.sjs?xhr. (Reason: CORS header ‘Access-Control-Allow-Origin’ missing)."]
[task 2020-08-07T13:41:13.435Z] 13:41:13     INFO - Console message: [JavaScript Warning: "HTTPS-Only Mode: Upgrading insecure request “http://example.com/browser/toolkit/components/httpsonlyerror/tests/browser/file_upgrade_insecure_server.sjs?nestedimg” to use “https”." {file: "http://example.com/browser/toolkit/components/httpsonlyerror/tests/browser/file_upgrade_insecure_server.sjs?nestedimg" line: 0}]
[task 2020-08-07T13:41:13.435Z] 13:41:13     INFO - Console message: [JavaScript Warning: "HTTPS-Only Mode: Upgrading insecure request “http://example.com/browser/toolkit/components/httpsonlyerror/tests/browser/file_upgrade_insecure_server.sjs?nestedimg” to use “https”." {file: "http://example.com/browser/toolkit/components/httpsonlyerror/tests/browser/file_upgrade_insecure_server.sjs?nestedimg" line: 0}]
[task 2020-08-07T13:41:13.435Z] 13:41:13     INFO - TEST-PASS | toolkit/components/httpsonlyerror/tests/browser/browser_exception.js | Page should load normally after exception button was clicked. - true == true - 
[task 2020-08-07T13:41:13.435Z] 13:41:13     INFO - TEST-PASS | toolkit/components/httpsonlyerror/tests/browser/browser_exception.js | Request 'content' should be loaded with HTTP.' - 
[task 2020-08-07T13:41:13.436Z] 13:41:13     INFO - TEST-PASS | toolkit/components/httpsonlyerror/tests/browser/browser_exception.js | Request 'img' should be loaded with HTTP.' - 
[task 2020-08-07T13:41:13.436Z] 13:41:13     INFO - TEST-PASS | toolkit/components/httpsonlyerror/tests/browser/browser_exception.js | Request 'xhr' should be loaded with HTTP.' - 
[task 2020-08-07T13:41:13.436Z] 13:41:13     INFO - Buffered messages finished
[task 2020-08-07T13:41:13.436Z] 13:41:13     INFO - TEST-UNEXPECTED-FAIL | toolkit/components/httpsonlyerror/tests/browser/browser_exception.js | Request 'iframe' should be loaded with HTTP.' - Got "error", expected "ok"
[task 2020-08-07T13:41:13.436Z] 13:41:13     INFO - Stack trace:
[task 2020-08-07T13:41:13.436Z] 13:41:13     INFO - chrome://mochikit/content/browser-test.js:test_is:1327
[task 2020-08-07T13:41:13.436Z] 13:41:13     INFO - chrome://mochitests/content/browser/toolkit/components/httpsonlyerror/tests/browser/browser_exception.js:null:112
[task 2020-08-07T13:41:13.437Z] 13:41:13     INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-08-07T13:41:13.440Z] 13:41:13     INFO - TEST-UNEXPECTED-FAIL | toolkit/components/httpsonlyerror/tests/browser/browser_exception.js | Request 'nestedimg' should be loaded with HTTP.' - Got "error", expected "ok"
[task 2020-08-07T13:41:13.440Z] 13:41:13     INFO - Stack trace:
[task 2020-08-07T13:41:13.440Z] 13:41:13     INFO - chrome://mochikit/content/browser-test.js:test_is:1327
[task 2020-08-07T13:41:13.440Z] 13:41:13     INFO - chrome://mochitests/content/browser/toolkit/components/httpsonlyerror/tests/browser/browser_exception.js:null:112
[task 2020-08-07T13:41:13.441Z] 13:41:13     INFO - Console message: [JavaScript Warning: "HTTPS-Only Mode: Upgrading insecure request “http://example.com/browser/toolkit/components/httpsonlyerror/tests/browser/file_upgrade_insecure_server.sjs?queryresult=http://example.com/browser/toolkit/components/httpsonlyerror/tests/browser/” to use “https”." {file: "http://example.com/browser/toolkit/components/httpsonlyerror/tests/browser/file_upgrade_insecure_server.sjs?queryresult=http://example.com/browser/toolkit/components/httpsonlyerror/tests/browser/" line: 0}]
[task 2020-08-07T13:41:13.559Z] 13:41:13     INFO - Console message: OpenGL compositor Initialized Succesfully.
[task 2020-08-07T13:41:13.559Z] 13:41:13     INFO - Version: 2.1 INTEL-12.9.22
[task 2020-08-07T13:41:13.559Z] 13:41:13     INFO - Vendor: Intel Inc.
[task 2020-08-07T13:41:13.559Z] 13:41:13     INFO - Renderer: Intel Iris OpenGL Engine
[task 2020-08-07T13:41:13.559Z] 13:41:13     INFO - FBO Texture Target: TEXTURE_2D
[task 2020-08-07T13:41:13.852Z] 13:41:13     INFO - Console message: [JavaScript Warning: "HTTPS-Only Mode: Upgrading insecure request “http://supports-insecure.expired.example.com/browser/toolkit/components/httpsonlyerror/tests/browser/file_upgrade_insecure_server.sjs?content” to use “https”."]
[task 2020-08-07T13:41:13.906Z] 13:41:13     INFO - Console message: [JavaScript Error: "HTTPS-Only Mode: Upgrading insecure request “https://supports-insecure.expired.example.com/browser/toolkit/components/httpsonlyerror/tests/browser/file_upgrade_insecure_server.sjs?content” failed. (M21-C12276)"]
[task 2020-08-07T13:41:14.154Z] 13:41:14     INFO - Loading and waiting for the error page
[task 2020-08-07T13:41:14.157Z] 13:41:14     INFO - TEST-PASS | toolkit/components/httpsonlyerror/tests/browser/browser_exception.js | openInsecureButton should exist. - true == true - 
[task 2020-08-07T13:41:14.157Z] 13:41:14     INFO - Console message: [JavaScript Error: "HTTPS-Only Mode: Not upgrading insecure request “http://supports-insecure.expired.example.com/browser/toolkit/components/httpsonlyerror/tests/browser/file_upgrade_insecure_server.sjs?content” because it is exempt."]
[task 2020-08-07T13:41:14.211Z] 13:41:14     INFO - Console message: [JavaScript Error: "HTTPS-Only Mode: Not upgrading insecure request “http://example.com/browser/toolkit/components/httpsonlyerror/tests/browser/file_upgrade_insecure_server.sjs?img” because it is exempt." {file: "http://example.com/browser/toolkit/components/httpsonlyerror/tests/browser/file_upgrade_insecure_server.sjs?img" line: 0}]
[task 2020-08-07T13:41:14.211Z] 13:41:14     INFO - Console message: [JavaScript Error: "HTTPS-Only Mode: Not upgrading insecure request “http://example.com/browser/toolkit/components/httpsonlyerror/tests/browser/file_upgrade_insecure_server.sjs?xhr” because it is exempt." {file: "http://supports-insecure.expired.example.com/browser/toolkit/components/httpsonlyerror/tests/browser/file_upgrade_insecure_server.sjs?content" line: 12}]
[task 2020-08-07T13:41:14.219Z] 13:41:14     INFO - Console message: [JavaScript Warning: "HTTPS-Only Mode: Upgrading insecure request “http://example.com/browser/toolkit/components/httpsonlyerror/tests/browser/file_upgrade_insecure_server.sjs?iframe” to use “https”." {file: "http://example.com/browser/toolkit/components/httpsonlyerror/tests/browser/file_upgrade_insecure_server.sjs?iframe" line: 0}]
[task 2020-08-07T13:41:14.219Z] 13:41:14     INFO - Console message: [JavaScript Error: "HTTPS-Only Mode: Not upgrading insecure request “http://example.com/browser/toolkit/components/httpsonlyerror/tests/browser/file_upgrade_insecure_server.sjs?img” because it is exempt." {file: "http://example.com/browser/toolkit/components/httpsonlyerror/tests/browser/file_upgrade_insecure_server.sjs?img" line: 0}]
[task 2020-08-07T13:41:14.234Z] 13:41:14     INFO - Console message: [JavaScript Error: "HTTPS-Only Mode: Not upgrading insecure request “http://example.com/browser/toolkit/components/httpsonlyerror/tests/browser/file_upgrade_insecure_server.sjs?xhr” because it is exempt." {file: "http://example.com/browser/toolkit/components/httpsonlyerror/tests/browser/file_upgrade_insecure_server.sjs?xhr" line: 0}]
[task 2020-08-07T13:41:14.234Z] 13:41:14     INFO - Console message: [JavaScript Error: "Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at http://example.com/browser/toolkit/components/httpsonlyerror/tests/browser/file_upgrade_insecure_server.sjs?xhr. (Reason: CORS header ‘Access-Control-Allow-Origin’ missing)."]
[task 2020-08-07T13:41:14.293Z] 13:41:14     INFO - Console message: [JavaScript Warning: "HTTPS-Only Mode: Upgrading insecure request “http://example.com/browser/toolkit/components/httpsonlyerror/tests/browser/file_upgrade_insecure_server.sjs?nestedimg” to use “https”." {file: "http://example.com/browser/toolkit/components/httpsonlyerror/tests/browser/file_upgrade_insecure_server.sjs?nestedimg" line: 0}]
[task 2020-08-07T13:41:14.293Z] 13:41:14     INFO - Console message: [JavaScript Warning: "HTTPS-Only Mode: Upgrading insecure request “http://example.com/browser/toolkit/components/httpsonlyerror/tests/browser/file_upgrade_insecure_server.sjs?nestedimg” to use “https”." {file: "http://example.com/browser/toolkit/components/httpsonlyerror/tests/browser/file_upgrade_insecure_server.sjs?nestedimg" line: 0}]
[task 2020-08-07T13:41:14.317Z] 13:41:14     INFO - TEST-PASS | toolkit/components/httpsonlyerror/tests/browser/browser_exception.js | Page should load normally after exception button was clicked. - true == true - 
[task 2020-08-07T13:41:14.318Z] 13:41:14     INFO - TEST-PASS | toolkit/components/httpsonlyerror/tests/browser/browser_exception.js | Request 'content' should be loaded with HTTP.' - 
[task 2020-08-07T13:41:14.318Z] 13:41:14     INFO - TEST-PASS | toolkit/components/httpsonlyerror/tests/browser/browser_exception.js | Request 'img' should be loaded with HTTP.' - 
[task 2020-08-07T13:41:14.318Z] 13:41:14     INFO - TEST-PASS | toolkit/components/httpsonlyerror/tests/browser/browser_exception.js | Request 'xhr' should be loaded with HTTP.' - 
[task 2020-08-07T13:41:14.318Z] 13:41:14     INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-08-07T13:41:14.318Z] 13:41:14     INFO - TEST-UNEXPECTED-FAIL | toolkit/components/httpsonlyerror/tests/browser/browser_exception.js | Request 'iframe' should be loaded with HTTP.' - Got "error", expected "ok"
[task 2020-08-07T13:41:14.319Z] 13:41:14     INFO - Stack trace:
[task 2020-08-07T13:41:14.319Z] 13:41:14     INFO - chrome://mochikit/content/browser-test.js:test_is:1327
[task 2020-08-07T13:41:14.319Z] 13:41:14     INFO - chrome://mochitests/content/browser/toolkit/components/httpsonlyerror/tests/browser/browser_exception.js:null:112
[task 2020-08-07T13:41:14.319Z] 13:41:14     INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-08-07T13:41:14.325Z] 13:41:14     INFO - TEST-UNEXPECTED-FAIL | toolkit/components/httpsonlyerror/tests/browser/browser_exception.js | Request 'nestedimg' should be loaded with HTTP.' - Got "error", expected "ok"
[task 2020-08-07T13:41:14.325Z] 13:41:14     INFO - Stack trace:
[task 2020-08-07T13:41:14.325Z] 13:41:14     INFO - chrome://mochikit/content/browser-test.js:test_is:1327
[task 2020-08-07T13:41:14.325Z] 13:41:14     INFO - chrome://mochitests/content/browser/toolkit/components/httpsonlyerror/tests/browser/browser_exception.js:null:112
[task 2020-08-07T13:41:14.449Z] 13:41:14     INFO - Leaving test bound 
[task 2020-08-07T13:41:14.450Z] 13:41:14     INFO - GECKO(23438) | MEMORY STAT | vsize 7060MB | residentFast 323MB | heapAllocated 138MB
[task 2020-08-07T13:41:14.450Z] 13:41:14     INFO - TEST-OK | toolkit/components/httpsonlyerror/tests/browser/browser_exception.js | took 1612ms
Flags: needinfo?(ckerschb)

(In reply to Bogdan Tara[:bogdan_tara | bogdant] from comment #6)

FWIW, slightly reverted the changeset to reflect current behavior in the tree and we should re-evaluate our behavior regarding top-level loads and iframe loads when added to the permission Manager. I filed Bug 1658264 to do that.

Flags: needinfo?(ckerschb)
Pushed by dluca@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/375f4410ee3a
Simplify TestSitePermission within nsHTTPSOnlyUtils r=necko-reviewers,JulianWels,dragana
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
You need to log in before you can comment on or make changes to this bug.