1657616 - Remove the link to StopBadware.org in SafeBrowsing interstitial page

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, task, P2)

Description

[Dimi Lee [:dimi]]

In SafeBrowsing interstitial page, it links to stopBadWare's page to help users learn how to protect their computer. However, the service of StopBadware will be down soon, we should remove the link in the interstitial page

Comment 2

[Dimi Lee [:dimi]]

Attachment: Bug 1657616 - Remove the link to StopBadware.org in SafeBrowsing interstitial page r=gcp

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b0ea8d83462f
Remove the link to StopBadware.org in SafeBrowsing interstitial page r=gcp,fluent-reviewers,flod

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out changeset b0ea8d83462f (bug 1657616) for es lint failure on blockedSite.js

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedTaskRun=VTNNaJlxQXO1e8E_ZxMMSw.0&fromchange=b0ea8d83462fe713c8f104608a6b04004d02ae38&tochange=b7d570fb9d40e4d62f80e2fb79c2c1461068261f&searchStr=linting%2Copt%2Cjavascript%2Cchecks%2Csource-test-mozlint-eslint%2Ces

Backout link: https://hg.mozilla.org/integration/autoland/rev/b7d570fb9d40e4d62f80e2fb79c2c1461068261f

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=312399355&repo=autoland&lineNumber=270

task 2020-08-07T14:46:35.628Z] 14:46:35.627 eslint (97) | Command: /usr/local/bin/node /builds/worker/checkouts/gecko/node_modules/eslint/bin/eslint.js --ext [js,jsm,jsx,xul,html,xhtml] --format json --no-error-on-unmatched-pattern --quiet --ignore-pattern browser/components/pocket/content/panels/js/vendor --ignore-pattern dom/canvas/test/webgl-conf/checkout --ignore-pattern media/libjpeg --ignore-pattern js/src/vtune/ittnotify_static.h --ignore-pattern dom/media/platforms/ffmpeg/ffmpeg58 --ignore-pattern dom/media/webspeech/recognition/energy_endpointer.cc --ignore-pattern media/kiss_fft --ignore-pattern dom/u2f/tests/pkijs --ignore-pattern media/libvorbis --ignore-pattern dom/media/webspeech/recognition/energy_endpointer.h --ignore-pattern dom/media/webspeech/recognition/endpointer.h --ignore-pattern media/mtransport/third_party --ignore-pattern media/libopus --ignore-pattern media/openmax_il --ignore-pattern media/ffvpx --ignore-pattern media/libaom --ignore-pattern js/src/octane --ignore-pattern js/src/vtune/ittnotify_config.h --ignore-pattern xpcom/io/crc32c.c --ignore-pattern dom/tests/mochitest/dom-level2-core --ignore-pattern media/libyuv --ignore-pattern media/libspeex_resampler --ignore-pattern js/src/vtune/jitprofiling.c --ignore-pattern js/src/vtune/ittnotify_types.h --ignore-pattern media/libnestegg --ignore-pattern media/mp4parse-rust --ignore-pattern modules/fdlibm --ignore-pattern media/libcubeb --ignore-pattern modules/xz-embedded --ignore-pattern extensions/spellcheck/hunspell/src --ignore-pattern media/libdav1d --ignore-pattern js/src/dtoa.c --ignore-pattern js/src/jit/arm64/vixl --ignore-pattern js/src/zydis --ignore-pattern modules/freetype2 --ignore-pattern media/webrtc/signaling/src/sdp/sipcc --ignore-pattern dom/imptests --ignore-pattern js/src/vtune/ittnotify_static.c --ignore-pattern js/src/ctypes/libffi --ignore-pattern modules/brotli --ignore-pattern browser/extensions/formautofill/content/third-party --ignore-pattern browser/extensions/screenshots/build/raven.js --ignore-pattern dom/media/gmp/rlz --ignore-pattern dom/webauthn/cbor-cpp --ignore-pattern dom/webauthn/tests/pkijs --ignore-pattern dom/media/webspeech/recognition/endpointer.cc --ignore-pattern js/src/editline --ignore-pattern dom/media/webvtt/vtt.jsm --ignore-pattern xpcom/build/mach_override.c --ignore-pattern dom/media/gmp/widevine-adapter/content_decryption_module_export.h --ignore-pattern media/libsoundtouch --ignore-pattern dom/media/gmp/widevine-adapter/content_decryption_module.h --ignore-pattern js/src/vtune/legacy --ignore-pattern media/libogg --ignore-pattern dom/tests/mochitest/dom-level1-core --ignore-pattern media/libpng --ignore-pattern dom/media/webaudio/test/blink --ignore-pattern media/libmkv --ignore-pattern media/libvpx --ignore-pattern js/src/vtune/disable_warnings.h --ignore-pattern media/libtheora --ignore-pattern dom/media/gmp/widevine-adapter/content_decryption_module_proxy.h --ignore-pattern dom/media/gmp/widevine-adapter/content_decryption_module_ext.h --ignore-pattern dom/tests/mochitest/dom-level2-html --ignore-pattern browser/components/newtab/vendor --ignore-pattern media/libtremor --ignore-pattern dom/media/platforms/ffmpeg/libav53 --ignore-pattern media/webrtc/trunk --ignore-pattern js/src/vtune/ittnotify.h --ignore-pattern js/src/vtune/jitprofiling.h --ignore-pattern dom/media/webspeech/recognition/energy_endpointer_params.cc --ignore-pattern dom/media/platforms/ffmpeg/libav55 --ignore-pattern media/libwebp --ignore-pattern dom/media/platforms/ffmpeg/libav54 --ignore-pattern modules/zlib --ignore-pattern xpcom/build/mach_override.h --ignore-pattern dom/tests/mochitest/ajax --ignore-pattern dom/media/webspeech/recognition/energy_endpointer_params.h --ignore-pattern media/openmax_dl --ignore-pattern browser/components/translation/cld2 --ignore-pattern dom/media/platforms/ffmpeg/ffmpeg57 --ignore-pattern modules/woff2 /builds/worker/checkouts/gecko/dom /builds/worker/checkouts/gecko/hal /builds/worker/checkouts/gecko/accessible /builds/worker/checkouts/gecko/view /builds/worker/checkouts/gecko/docshell /builds/worker/checkouts/gecko/media /builds/worker/checkouts/gecko/modules /builds/worker/checkouts/gecko/js /builds/worker/checkouts/gecko/xpcom /builds/worker/checkouts/gecko/layout /builds/worker/checkouts/gecko/caps /builds/worker/checkouts/gecko/extensions /builds/worker/checkouts/gecko/browser /builds/worker/checkouts/gecko/widget
[task 2020-08-07T14:47:05.539Z] 14:47:05.538 eslint (98) | Finished in 30.10 seconds
[task 2020-08-07T14:48:07.269Z] 14:48:07.269 eslint (96) | Finished in 91.84 seconds
[task 2020-08-07T14:53:25.675Z] 14:53:25.675 eslint (99) | Finished in 410.24 seconds
[task 2020-08-07T14:53:46.896Z] 14:53:46.895 eslint (97) | Finished in 431.46 seconds
[task 2020-08-07T14:53:46.900Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/browser/base/content/blockedSite.js:126:5 | Replace `"malware":·"safeb-blocked-malware-page-learn-more-sumo"` with `malware:·"safeb-blocked-malware-page-learn-more-sumo",` (prettier/prettier)
[task 2020-08-07T14:53:46.900Z] TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/browser/base/content/blockedSite.js:127:4 | Insert `;` (prettier/prettier)
[taskcluster 2020-08-07 14:53:47.442Z] === Task Finished ===

Comment 5

[Joni Chan]

I've removed references to stopbadadware in https://support.mozilla.org/en-US/kb/how-does-phishing-and-malware-protection-work

I didn't see any other articles that mentioned it.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/203adac4658d
Remove the link to StopBadware.org in SafeBrowsing interstitial page r=gcp,fluent-reviewers,flod

Comment 7

[Dimi Lee [:dimi]]

(In reply to Joni Chan from comment #5)

I've removed references to stopbadadware in https://support.mozilla.org/en-US/kb/how-does-phishing-and-malware-protection-work

I didn't see any other articles that mentioned it.

Thank you!

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/203adac4658d