1657666 - Newtab popular topics telemetry event fix

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect)

Description

[Scott [:thecount] Downe]

Right now the helper function we're using for telemetry for the popular topics clicks is wrong, which is causing the event to not work correctly.

Comment 1

[Scott [:thecount] Downe]

To test:

1. Set browser.ping-centre.log to true
2. Set browser.newtabpage.activity-stream.telemetry to true
3. Set browser.newtabpage.activity-stream.discoverystream.config to {"api_key_pref": "extensions.pocket.oAuthConsumerKey", "collapsible": true, "enabled": true, "show_spocs": true, "hardcoded_layout": false, "personalized": true, "layout_endpoint": "https://getpocket.cdn.mozilla.net/v3/newtab/layout?version=1&consumer_key=$apiKey&layout_variant=topics-improved-layout", "unused_key": "unused_3"}
4. Open a newtab
5. Open the multi process debugger
6. Click a popular topic.

Expected: Should still navigate to the popular topic on the pocket page. Should also see a similar log in the multi processes debugger that looks like this:
TELEMETRY PING (activity-stream): {"experiments":{},"locale":"en-US","version":"81.0a1","release_channel":"default","addon_version":"111","user_prefs":255,"session_id":"{111}","page":"about:newtab","event":"CLICK","source":"POPULAR_TOPICS","action_position":0,"value":"{"topic":"business"}","client_id":"111","browser_session_id":"111"}

Comment 2

[Scott [:thecount] Downe]

Attachment: Bug 1657666 - Fix telemetry event for newtab popular topics.

Comment 3

[Scott [:thecount] Downe]

[Tracking Requested - why for this release]: Broken telemetry fix impacting an experiment.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/867cc25b2db6
Fix telemetry event for newtab popular topics. r=nanj

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/867cc25b2db6

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:thecount, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 7

[Scott [:thecount] Downe]

Comment on attachment 9168657 [details]
Bug 1657666 - Fix telemetry event for newtab popular topics.

Beta/Release Uplift Approval Request

• User impact if declined: Impacts to an experiment
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: To test:

1. Set browser.ping-centre.log to true
2. Set browser.newtabpage.activity-stream.telemetry to true
3. Set browser.newtabpage.activity-stream.discoverystream.config to {"api_key_pref": "extensions.pocket.oAuthConsumerKey", "collapsible": true, "enabled": true, "show_spocs": true, "hardcoded_layout": false, "personalized": true, "layout_endpoint": "https://getpocket.cdn.mozilla.net/v3/newtab/layout?version=1&consumer_key=$apiKey&layout_variant=topics-improved-layout", "unused_key": "unused_3"}
4. Open a newtab
5. Open the multi process debugger
6. Click a popular topic.

Expected: Should still navigate to the popular topic on the pocket page. Should also see a similar log in the multi processes debugger that looks like this:
TELEMETRY PING (activity-stream): {"experiments":{},"locale":"en-US","version":"81.0a1","release_channel":"default","addon_version":"111","user_prefs":255,"session_id":"{111}","page":"about:newtab","event":"CLICK","source":"POPULAR_TOPICS","action_position":0,"value":"{"topic":"business"}","client_id":"111","browser_session_id":"111"}

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The code it so small, just changing two lines on a telemetry call.
• String changes made/needed: none

Comment 8

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this enhancement, using the steps provided in comment 1 and I can confirm that the telemetry ping displayed in the "Multi Processes Debugger" is similar to the one from the testing instructions.

Verified using the latest Firefox Nightly (81.0a1 Build ID - 20200810213634) installed on Windows 10 x64, Mac 10.15, and Ubuntu 18.04 x64.

Comment 9

[Julien Cristau [:jcristau]]

Comment on attachment 9168657 [details]
Bug 1657666 - Fix telemetry event for newtab popular topics.

approved for 80.0b7

Comment 10

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/68d145de5fd3

Comment 11

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this enhancement, using the steps provided in comment 1 and I can confirm that the telemetry ping displayed in the "Multi Processes Debugger" is similar to the one from the testing instructions.

Verified using the latest Firefox Beta (80.0b7 Build ID - 20200811133449) installed on Windows 10 x64, Mac 10.15, and Ubuntu 18.04 x64.