1657688 - [wpt-sync] Sync PR 24906 - [css-flex] Update test to wait for image load before checking sizes

Status: RESOLVED FIXED

(Core :: Layout: Flexbox, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 24906 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/24906
Details from upstream follow.

David Grogan <[e-mail]> wrote:

[css-flex] Update test to wait for image load before checking sizes

This test flaked on me locally with:
height expected 100 but got 0

Which is consistent with calling checkLayout before the image has
loaded, but not a guarantee that's what's happening. I haven't been able
to reproduce it.

In any case, this change can't hurt.

Change-Id: I1bf8ccb935845c6e5e4529694c2d77e3f4a529a3

Reviewed-on: https://chromium-review.googlesource.com/2340735
WPT-Export-Revision: e77b92d4ac59fd26ab91fb412fff6a3ac23e8647

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=9bcdbc0f2c3b01c6407db995687c1e15c68197dd

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=92193897837c36c9cecf4fd34c7e98f7c8e0678f

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
PASS: 1

Chrome

OK : 1
PASS: 1

Safari

OK : 1
FAIL: 1

Links

GitHub PR Head
GitHub PR Base

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3e1d54561c83
[wpt PR 24906] - [css-flex] Update test to wait for image load before checking sizes, a=testonly

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8abece86e093
[wpt PR 24906] - [css-flex] Update test to wait for image load before checking sizes, a=testonly

Comment 6

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/8abece86e093