1657752 - Picture-in-Picture toggle should have an alt label for screen readers

Status: NEW

(Toolkit :: Picture-in-Picture, defect, P3)

Description

[Mike Conley (:mconley) (:⚙️)]

Mode 2 of the toggle variations is just an icon with no text if the user has already used Picture-in-Picture. We should have alt text for screenreader users who wonder what that button is.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1657752 - Make sure the Picture-in-Picture toggle variations have an aria-label. r?mstriemer!

Comment 2

[:Gijs (he/him)]

Mike, does this mean the toggle which we just enabled for 82 release won't have an accessible label? That'd be unfortunate...

From a quick skim, it seems that the discussion on the phab issue is about tab focusability of the toggle; that's a bit of an interesting topic, see bug 494175 - I don't think we should try to tackle it piecemeal in this bug. :-)

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Dropping to P3 since we have a keyboard shortcut to enter into PiP and this toggle probably shouldn't be keyboard accessible for that reason.