1657897 - Convert TRR split horizon mitigations to a doh-rollout heuristic

Status: RESOLVED FIXED

(Core :: Networking: DNS, task, P2)

Description

[Valentin Gosu [:valentin] (he/him)]

In bug 1656862 comment 8 we determined that a large part of the TRR_EXCLUDED value of the TRR_SKIP_REASON telemetry probe is caused by the split horizon mitigations on Windows - detection of VPN, Proxy, NRPT.

We should convert the detection to a doh-rollout heuristic because:

• it allows us to see the proportion of users who trigger each mitigation
• it wouldn't show TRR=on when in fact we skip doing TRR
• it would allow users who turn on TRR manually to actually use it properly without having to change other prefs

Comment 1

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1657897 - Convert TRR split horizon mitigations to a doh-rollout heuristic

Comment 2

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1657897 - Remove code that bypasses TRR when platform indications are triggered r=dragana

Depends on D86366

Comment 3

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1657897 - Change event telemetry definition to include platform key r=tdsmith

Depends on D86367

Comment 4

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1657897 - Add test for platform indication DoH heuristic

Depends on D86369

Comment 5

[Valentin Gosu [:valentin] (he/him)]

Attachment: trr_request.md

Comment 6

[Tim Smith (inactive) 👨‍🔬 [:tdsmith]]

Comment on attachment 9169142 [details]
trr_request.md

1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, in the probe definition files and the Probe Dictionary.

2. Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, the Firefox telemetry opt-out.

3. If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Valentin will monitor the telemetry.

4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, technical data.

5. Is the data collection request for default-on or default-off?

Default-on.

6. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No.

7. Is the data collection covered by the existing Firefox privacy notice?

Yes.

8. Does there need to be a check-in in the future to determine whether to renew the data?

No, permanent collection.

9. Does the data collection use a third-party collection tool?

No.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/58191045acd3
Convert TRR split horizon mitigations to a doh-rollout heuristic r=nhnt11
https://hg.mozilla.org/integration/autoland/rev/e90913de88ff
Remove code that bypasses TRR when platform indications are triggered r=dragana,necko-reviewers
https://hg.mozilla.org/integration/autoland/rev/a82fff031cd8
Change event telemetry definition to include platform key r=tdsmith
https://hg.mozilla.org/integration/autoland/rev/bf0c6945edbe
Add test for platform indication DoH heuristic r=nhnt11

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/58191045acd3
https://hg.mozilla.org/mozilla-central/rev/e90913de88ff
https://hg.mozilla.org/mozilla-central/rev/a82fff031cd8
https://hg.mozilla.org/mozilla-central/rev/bf0c6945edbe