1657976 - Multistage welcome screen should pick FxA endpoint dynamically

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Punam Dahiya [:pdahiya]]

With bug 1653613 fix, FxA endpoint should be dynamically picked from browser.newtabpage.activity-stream.fxaccounts.endpoint or generated with a call to FxAccounts.config.promise***URI

https://bugzilla.mozilla.org/show_bug.cgi?id=1657586#c4

Comment 1

[Kate Hudson :k88hudson]

I would recommend switching the multistage code to use the SHOW_FIREFOX_ACCOUNTS special message action instead of OPEN_URL, since that already dynamically gets the right Firefox accounts endpoint. (see https://firefox-source-docs.mozilla.org/toolkit/components/messaging-system/docs/SpecialMessageActionSchemas/index.html?highlight=show_firefox_accounts#show-firefox-accounts)

You will need to extend the SMA to accept extraParams (like all your flow params).

Comment 2

[Punam Dahiya [:pdahiya]]

Attachment: Bug 1657976 - Multistage welcome screen should pick FxA endpoint dynamically

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/de9369f53613
Multistage welcome screen should pick FxA endpoint dynamically r=andreio

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/de9369f53613

Comment 5

[Punam Dahiya [:pdahiya]]

QA steps to verify:

1. Go to about:welcome and click on FxA signin link
2. Verify redirected endpoint is picked from pref 'identity.fxaccounts.remote.root'

FxA signin link for CN builds should redirect to https://accounts.firefox.com.cn as per the endpoint set in pref 'identity.fxaccounts.remote.root'

Comment 6

[Punam Dahiya [:pdahiya]]

NI @hectorz to help point to FxCN repacked build for beta 81 and Nightly 82 to verify FxA endpoint in about:welcome is pointing to https://accounts.firefox.com.cn . Thanks!

https://bugzilla.mozilla.org/show_bug.cgi?id=1657586#c3

Comment 7

[Hector Zhao [:hectorz]]

(In reply to Punam Dahiya [:pdahiya] from comment #6)

NI @hectorz to help point to FxCN repacked build for beta 81 and Nightly 82 to verify FxA endpoint in about:welcome is pointing to https://accounts.firefox.com.cn . Thanks!

Hi Punam,

Partner repacks are not created for earlier betas, they will be first built with Fx 81.0b81. Even then, overrides for Fx 80 in current distribution.ini might take precedence.

I think our desktop QA Yanfang had verified this fix with Nightly 81.0a1 and manually modified distribution files already, I'll let her confirm in the bug.

Comment 8

[Yanfang Liu]

Verified as fixed in Nightly 81.0a1 and Fx80 with modified distribution files.