Closed Bug 1657976 Opened 6 months ago Closed 5 months ago

Multistage welcome screen should pick FxA endpoint dynamically

Categories

(Firefox :: Messaging System, enhancement, P1)

enhancement

Tracking

()

VERIFIED FIXED
81 Branch
Iteration:
81.2 - Aug 10 - Aug 23
Tracking Status
firefox80 --- wontfix
firefox81 --- verified

People

(Reporter: pdahiya, Assigned: pdahiya)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

With bug 1653613 fix, FxA endpoint should be dynamically picked from browser.newtabpage.activity-stream.fxaccounts.endpoint or generated with a call to FxAccounts.config.promise***URI

https://bugzilla.mozilla.org/show_bug.cgi?id=1657586#c4

Depends on: 1653613
Assignee: nobody → pdahiya
Priority: -- → P1
Iteration: --- → 81.2 - Aug 10 - Aug 23

I would recommend switching the multistage code to use the SHOW_FIREFOX_ACCOUNTS special message action instead of OPEN_URL, since that already dynamically gets the right Firefox accounts endpoint. (see https://firefox-source-docs.mozilla.org/toolkit/components/messaging-system/docs/SpecialMessageActionSchemas/index.html?highlight=show_firefox_accounts#show-firefox-accounts)

You will need to extend the SMA to accept extraParams (like all your flow params).

Pushed by pdahiya@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/de9369f53613
Multistage welcome screen should pick FxA endpoint dynamically r=andreio
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch

QA steps to verify:

  1. Go to about:welcome and click on FxA signin link
  2. Verify redirected endpoint is picked from pref 'identity.fxaccounts.remote.root'

FxA signin link for CN builds should redirect to https://accounts.firefox.com.cn as per the endpoint set in pref 'identity.fxaccounts.remote.root'

NI @hectorz to help point to FxCN repacked build for beta 81 and Nightly 82 to verify FxA endpoint in about:welcome is pointing to https://accounts.firefox.com.cn . Thanks!

https://bugzilla.mozilla.org/show_bug.cgi?id=1657586#c3

Flags: needinfo?(bzhao)

(In reply to Punam Dahiya [:pdahiya] from comment #6)

NI @hectorz to help point to FxCN repacked build for beta 81 and Nightly 82 to verify FxA endpoint in about:welcome is pointing to https://accounts.firefox.com.cn . Thanks!

Hi Punam,

Partner repacks are not created for earlier betas, they will be first built with Fx 81.0b81. Even then, overrides for Fx 80 in current distribution.ini might take precedence.

I think our desktop QA Yanfang had verified this fix with Nightly 81.0a1 and manually modified distribution files already, I'll let her confirm in the bug.

Flags: needinfo?(bzhao) → needinfo?(yliu)

Verified as fixed in Nightly 81.0a1 and Fx80 with modified distribution files.

Status: RESOLVED → VERIFIED
Flags: needinfo?(yliu)
You need to log in before you can comment on or make changes to this bug.