1658216 - 'Synchronize' button always disabled when only local calendars exist - impossible to reload .ics calendars without Thunderbird restart

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Thunderbird 78.1.0 on Windows 8.1

In the calendar view, the 'Synchronize' button in the toolbar is always disabled here. There are a bunch of application-internal local .ics calendars and up to Thunderbird 68, the latter could be reloaded by using the Synchronize button. Now the application has to be closed and launched again.

Comment 1

[Martin Schröder [:mschroeder]]

The could be a regression from bug 1621791.

Comment 2

[Martin Schröder [:mschroeder]]

Sebastian, what do you mean with "application-internal local .ics calendars"? Are these local (sqlite) or remote calendars (ics)?

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

(In reply to Martin Schröder [:martinschroeder] from comment #2)

Sebastian, what do you mean with "application-internal local .ics calendars"? Are these local (sqlite) or remote calendars (ics)?

Sorry, this was missing an "and": "application-internal and local .ics calendars".

Comment 4

[Magnus Melin [:mkmelin]]

Clarifying that it's when you only have local calendars.
https://searchfox.org/comm-central/rev/8a81725ff0230661a6a66f675c733d4b87645578/calendar/base/content/calendar-command-controller.js#205

Comment 5

[Lasana Murray]

Hello Sebastian. What are some of these internal changes you are referring to? Seems like bad form to have users manually sync local calendars.
Maybe we can have those changes handled automatically instead?

Edit: I misread this, what are these application-internal calendars?

Comment 6

[Lasana Murray]

It took me a while to understand what this bug is about. Patch coming.

Comment 7

[Lasana Murray]

Attachment: Bug 1658216 - Take ics calendars into account when disabling the synchronize button. r?darktrojan

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/06c9b6b4e89d
Take ics calendars into account when disabling the synchronize button. r=darktrojan

Comment 9

[Magnus Melin [:mkmelin]]

Comment on attachment 9207972 [details]
Bug 1658216 - Take ics calendars into account when disabling the synchronize button. r?darktrojan

[Approval Request Comment]
Minor safe regression fix.

Comment 10

[Wayne Mery (:wsmwk)]

Comment on attachment 9207972 [details]
Bug 1658216 - Take ics calendars into account when disabling the synchronize button. r?darktrojan

[Triage Comment]
Approved for esr78

Comment 11

[Rob Lemley [:rjl]]

Thunderbird 78.10.2:
https://hg.mozilla.org/releases/comm-esr78/rev/070456c32dc4