1658244 - "View Background Image" doesn't work for inlined SVG images

Status: RESOLVED FIXED

(Core :: DOM: Security, defect, P1)

Description

[:glob ✱]

Attachment: testcase

STR:

1. create content that has an inline SVG as a background image (see attached)
2. right click on background --> "View Background Image"

Expected:

• Navigated to the background's data: URL

Actual:

• Nothing, not even an error message

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[:glob ✱]

More:

• on BMO you'll see CSP warnings when trying to view the background image, this doesn't happen on the site where I found this issue so they are unrelated
• command-clicking on "View Background Image" opens the data: url in a new tab, however the content is blank. Interestingly enough the "Refresh" button is disabled on this tab
• focusing the address bar and hitting Return to navigate to the url results in SVG being correctly shown

Comment 3

[:glob ✱]

Oops, forgot to describe my Firefox version: I see this in the release channel (currently on 79) as well as nightly (81). fission is not enabled in either environment.

Comment 4

[Cameron McCormack (:heycam)]

mozregression points me to this range:

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=42151fcd6cfc216d147730d0f2c6a2acd52d22fd&tochange=a0eb21bf55e1c1ae0ba311e6f2273da05c712799

Looks like it's bug 1380959, which disallowed top-level data: URL navigations. We should probably allow it when it was triggered by View Source. Sounds similar to bug 1407891, too. Christian, do you know what we need to do here?

Comment 5

[Christoph Kerschbaumer [:ckerschb]]

I really can't tell why we are not logging to either the browser console, or the web console in that particular case.

Good news is, I have a patch which fixes the problem - will upload in a minute.

Comment 6

[Christoph Kerschbaumer [:ckerschb]]

Attachment: Bug 1658244: Allow view-background-image to open a data: URI by setting a flag on the loadinfo

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/869d82e5b984
Allow view-background-image to open a data: URI by setting a flag on the loadinfo r=Gijs

Comment 8

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/869d82e5b984