1658274 - Only send `install_stats` event when the add-on is installed (for the first time)

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[William Durand [:willdurand]]

We introduced a new install_stats event in Bug 1653020. This event should only be sent when an add-on is installed but the very first telemetry data shows that we're also sending it on add-on updates. We should not send this event in such a case.

We should check the install.existingAddon prop in AddonManager.recordInstallStatsEvent().

STR:

1. install an add-on from AMO, ideally not the latest version. There should be an install_stats event in about:telemetry
2. "Force update" this add-on, there should be no new install_stats event

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1658274 - Do not record install_stats telemetry event on installs related to addon updates. r?mixedpuppy!

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1653020

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2d30adfe2f27
Do not record install_stats telemetry event on installs related to addon updates. r=mixedpuppy

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/2d30adfe2f27

Comment 5

[Luca Greco [:rpl] [:luca] [:lgreco]]

Comment on attachment 9169137 [details]
Bug 1658274 - Do not record install_stats telemetry event on installs related to addon updates. r?mixedpuppy!

Beta/Release Uplift Approval Request

• User impact if declined: Without this patch, we wouldn't be able to collect the right add-on installation statistics for AMO. The change in Bug 1653020 was recording the install_stats also for addon updates, but it was meant to only be recorded for new installations.

Bug 1653020 has been uplifted to 80 Beta, and so we would like to uplift this follow up fix to avoid to collect the install_stats on addon updates from Firefox 80.

• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: The fix is covered by an automated test, but given that we do already have a quite short STR in comment 0 to verify this, it would be good to also QE verify it.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The fix is quite small (just avoids to record the event when the addon install object is related to an addon update) and it is covered by some new assertion added to the test case that covers this event.
• String changes made/needed:

Comment 6

[Julien Cristau [:jcristau] (back April 22)]

Comment on attachment 9169137 [details]
Bug 1658274 - Do not record install_stats telemetry event on installs related to addon updates. r?mixedpuppy!

approved for 80.0b7

Comment 7

[Alin Ilea, Desktop QA]

Reproduced the initial issue using an old Nightly 81.0a1 (build id: 20200806215439) using Windows 10. After add-on update there are 2 install_stats method events in about:telemetry.
Verified - Fixed in latest Nightly 81.0a1 (build id: 20200810213634). There is just the initial install_stats event in about:telemetry after updating the add-on.

Comment 8

[Julien Cristau [:jcristau] (back April 22)]

https://hg.mozilla.org/releases/mozilla-beta/rev/dc3523dfad03

Comment 9

[Alin Ilea, Desktop QA]

Verified - Fixed in latest Beta 80.0b7 (build id: 20200811133449). There is just the initial install_stats event in about:telemetry after updating the add-on.