1658279 - Optimise ArraySlice in CacheIR and Warp

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task)

Comment 1

[André Bargull [:anba]]

Attachment: Bug 1658279 - Part 1: Optimise ArraySlice in CacheIR and Warp. r=jandem!

Optimise Array.prototype.slice for packed arrays in CacheIR and Warp. Ion
also optimises slice() for non-packed arrays, but unless non-packed arrays
actually appear in user code, only optimising packed arrays should be okay
for now.

The second argument to slice() defaults to the array length, which means
we need a non-result version of LoadInt32ArrayLength.

Drive-by change:

• Move IonCacheIRCompiler::emitArrayPush to the bottom of the file,
  next to the other non-implemented methods. Also change from
  MOZ_ASSERT_UNREACHABLE to MOZ_CRASH for consistency.

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1658279 - Part 2: Remove unnecessary rooting in CacheIR. r=jandem!

Noticed while working on ArraySlice that ArrayPush and ArrayJoin have
unnecessary rooting. Also found some other places where rooting can
be omitted.

Depends on D86532

Comment 3

[André Bargull [:anba]]

Attachment: Bug 1658279 - Part 3: Don't create a template object for String when not constructing. r=jandem!

Calling String() shouldn't create a template object.

Depends on D86533

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/25869d8b6148
Part 1: Optimise ArraySlice in CacheIR and Warp. r=jandem
https://hg.mozilla.org/integration/autoland/rev/761efef13026
Part 2: Remove unnecessary rooting in CacheIR. r=jandem
https://hg.mozilla.org/integration/autoland/rev/728d98643858
Part 3: Don't create a template object for String when not constructing. r=jandem

Comment 5

[Razvan Maries]

Backed out for perma failures.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=windows%2C7%2Copt%2Cmochitests%2Ctest-windows7-32%2Fopt-mochitest-browser-chrome-e10s%2Cbc7&revision=728d9864385864dece4c4f6beaa3375ccd357606&selectedTaskRun=PLaZUwNjQt69WLxqR_eH_A.0

Log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=312924459&repo=autoland&lineNumber=2759

Backout: https://hg.mozilla.org/integration/autoland/rev/06e4f8547d78187f934074b2b4ff4d4d4d12efd5

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/75d3ba32d90a
Part 1: Optimise ArraySlice in CacheIR and Warp. r=jandem
https://hg.mozilla.org/integration/autoland/rev/5e227e32ff86
Part 2: Remove unnecessary rooting in CacheIR. r=jandem
https://hg.mozilla.org/integration/autoland/rev/37746b10f75c
Part 3: Don't create a template object for String when not constructing. r=jandem

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/75d3ba32d90a
https://hg.mozilla.org/mozilla-central/rev/5e227e32ff86
https://hg.mozilla.org/mozilla-central/rev/37746b10f75c