1658285 - Print preview gets closed if the tab is moved to a new window

Status: NEW

(Toolkit :: Printing, defect, P2)

Description

[Emil Ghitta, QA [:emilghitta]]

Affected versions

• 81.0a1 (BuildId:20200804215246)

Affected platforms

• Windows 10 64bit
• macOS 10.14
• Ubuntu 18.04 64bit

Preconditions

• Ensure that the print.tab_modal.enabled pref is set to true

Steps to reproduce

1. Launch Firefox.
2. Open a new tab and access the following link
3. Open the print preview.
4. Move the current tab (the tab from step 2) inside a new window or drag the tab in order to instantiate a new window containing the tab from step 2.

Expected result

• Print preview remains open for the tab mentioned in step 2.

Actual result

• Dragging the tab to a different window is closing the print preview.

Regression Range

• I don’t think that this is a regression

Notes

• The following error is being outputted inside the browser console each time the tab is moved in a new window while print preview is open: TypeError: can't access property "close", this._frame.contentWindow is nullSubDialog.jsm:296:7
• [Suggested Severity] I think that S3 fits for this one.

Comment 1

[Mark Striemer [:mstriemer]]

This seems fine to me. I don't think it's a real issue that it closes. The error however should be looked into.

Since that error is in SubDialog it might go away on its own when we switch to TabDialogBox.

Comment 2

[Mark Striemer [:mstriemer]]

I'm fine with this happening for the print dialog, the error is fixed since the move to TabDialogBox.

@pbz is this something the other TabDialogBox use cases might need to handle?

Comment 3

[Paul Zühlcke [:pbz]]

Detaching the tab calls TabDialogBox#abortAllDialogs here: https://searchfox.org/mozilla-central/rev/969fc7fa6c3c7fc489f53b7b7f8c902028b5169f/browser/base/content/browser.js#8957
I think this is fine for now.

Comment 4

[Blake Winton (:bwinton) (:☕️)]

[Moving front-end printing v82 bugs to v83.]

Comment 5

[Blake Winton (:bwinton) (:☕️)]

(Moving bugs to 86, part 2.)