1658323 - HTTPS-Only Mode: Have console message link to SUMO page

Status: RESOLVED FIXED

(DevTools :: Console, task, P1)

Description

[Christoph Kerschbaumer [:ckerschb]]

When HTTPS-Only Mode is enabled, we log request to the console with a category name of HTTPSOnly and we would like to have that linked to https://support.mozilla.org/en-US/kb/https-only-prefs

Quick STRs:

• In Nightly, go to about:preferences#privacy and enable HTTPS-Only Mode
• Open the Multi Process Browser Console
• Visit http.rip
• Observe multiple https-only messages e.g.
  HTTPS-Only Mode: Upgrading insecure request “http://http.rip/” to use “https”.
  but with no 'Link' to learn more about the message.

Comment 1

[Christoph Kerschbaumer [:ckerschb]]

Honza, can you help?

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Hello Christoph,

Do I understand correctly that you would like to have a [Learn more] link, like we have for other kind of warnings?
If so, this can be done by adding a new case for this error category in https://searchfox.org/mozilla-central/source/devtools/server/actors/errordocs.js

Comment 3

[Christoph Kerschbaumer [:ckerschb]]

Attachment: Bug 1658323: HTTPS-Only Mode: Have console message link to SUMO page

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9040cdaddc7c
HTTPS-Only Mode: Have console message link to SUMO page r=nchevobbe

Comment 5

[Noemi Erli[:noemi_erli]]

Backed out changeset 9040cdaddc7c (Bug 1658323) for causing multiple failures actors/webconsole related CLOSED TREE

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedTaskRun=LiaOf0_VRnKWBx2mbXl6Qg.0&resultStatus=pending%2Crunning%2Ctestfailed%2Cbusted%2Cexception&revision=9040cdaddc7c0b4d8e518bab272191759f3f6f6c

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=312710853&repo=autoland&lineNumber=16325
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=312711848&repo=autoland&lineNumber=4682
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=312709891&repo=autoland&lineNumber=10499
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=312711844&repo=autoland&lineNumber=107800

Backout: https://hg.mozilla.org/integration/autoland/rev/c0a363d993792e29152bbf0601c3f510b33b239f

Comment 6

[Christoph Kerschbaumer [:ckerschb]]

(In reply to Noemi Erli[:noemi_erli] from comment #5)

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=312710853&repo=autoland&lineNumber=16325

Nicolas, it works locally but it seems in the above error log there is
Console message: [JavaScript Error: "TypeError: Services.urlFormatter is undefined" {file: "resource://devtools/server/actors/errordocs.js" line: 13}]

Any idea what might be wrong there?

Comment 7

[Nicolas Chevobbe [:nchevobbe]]

Mhhh, looks like something happens in worker context, I'll check that.

Comment 8

[Christoph Kerschbaumer [:ckerschb]]

Joni, within this bug (precisely this patch D86577 ) we want console messages to link to the sumo page for https-only-prefs. While this works just fine in the non worker context, Services is not available in a worker context.

Long story short, is https://support.mozilla.org/kb/https-only-prefs redirecting to the right page? Or is there something else/better we can/should use in the worker context?

Comment 9

[Joni Chan]

Christoph, the issue should be fixed now and the link should now direct to the right page (it will say "waiting for approved content" or something to that effect.) Let me know if there's still an issue.

Comment 10

[Christoph Kerschbaumer [:ckerschb]]

(In reply to Joni Chan from comment #9)

Christoph, the issue should be fixed now and the link should now direct to the right page (it will say "waiting for approved content" or something to that effect.) Let me know if there's still an issue.

Great - works on my end too - thanks!

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8565ae515b6d
HTTPS-Only Mode: Have console message link to SUMO page r=nchevobbe

Comment 12

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/8565ae515b6d