1658353 - Allow front-end to mute/unmute all microphone tracks

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, enhancement)

Description

[Mike Conley (:mconley) (:⚙️)]

Logically similar to bug 1652884, but for microphone devices.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1658353 - Add global mute/unmute capability for microphones, with tests. r?jib!

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1658353 - Turn off the test microphone device when disabling even when full-duplex. r?jib!

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1658353 - Make MediaEngineDefaultAudioSource::Start idempotent per expectations. r?jib!

Depends on D86844

Comment 4

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1658353 - Add state for microphone muting to MediaManager. r?jib

Comment 5

[Phabricator Automation]

Comment on attachment 9169668 [details]
Bug 1658353 - Turn off the test microphone device when disabling even when full-duplex. r?jib!

Revision D86844 was moved to bug 1661341. Setting attachment 9169668 [details] to obsolete.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7aa764991e49
Add global mute/unmute capability for microphones, with tests. r=jib
https://hg.mozilla.org/integration/autoland/rev/acb933a440c7
Make MediaEngineDefaultAudioSource::Start idempotent per expectations. r=jib
https://hg.mozilla.org/integration/autoland/rev/fe37ed8ba008
Add state for microphone muting to MediaManager. r=jib

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out 6 changesets (bug 1643027, bug 1658353) for browser_parsable_css.js failures.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&selectedTaskRun=OLxFQK_jTIenzFDRrv5Apw.0&fromchange=e50501b546744c27d03e013dfc2039dc01a65643&tochange=4933a84ef41e9f6d9b959da1af16008b5843bca4&searchStr=mochitest-browser-chrome

Backout link: https://hg.mozilla.org/integration/autoland/rev/4933a84ef41e9f6d9b959da1af16008b5843bca4

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=314189635&repo=autoland&lineNumber=2779

[task 2020-08-27T15:15:34.819Z] 15:15:34     INFO - TEST-START | browser/base/content/test/static/browser_parsable_css.js
[task 2020-08-27T15:15:35.611Z] 15:15:35     INFO - TEST-INFO | started process screenshot
[task 2020-08-27T15:15:35.671Z] 15:15:35     INFO - TEST-INFO | screenshot: exit 0
[task 2020-08-27T15:15:35.672Z] 15:15:35     INFO - <snipped 57 output lines - if you need more context, please use SimpleTest.requestCompleteLog() in your test>
[task 2020-08-27T15:15:35.672Z] 15:15:35     INFO - Buffered messages logged at 15:15:35
[task 2020-08-27T15:15:35.673Z] 15:15:35     INFO - Console message: [JavaScript Warning: "Unknown pseudo-class or pseudo-element ‘-moz-ruby-base-container’.  Ruleset ignored due to bad selector." {file: "resource://gre-resources/ua.css?always-parse-css-0.4985088373806913" line: 124}]
...
...
...
[task 2020-08-27T15:15:35.718Z] 15:15:35     INFO - Console message: [JavaScript Warning: "Expected media feature name but found ‘-moz-windows-default-theme’." {file: "jar:file:///Z:/task_1598537966/build/application/firefox/browser/features/[e-mail]!/chrome/res/autocomplete-item.css?always-parse-css-0.4985088373806913" line: 12}]
[task 2020-08-27T15:15:35.718Z] 15:15:35     INFO - Buffered messages finished
[task 2020-08-27T15:15:35.718Z] 15:15:35     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_parsable_css.js | custom property `--device-button-hover-background-color` is not referenced - 
[task 2020-08-27T15:15:35.719Z] 15:15:35     INFO - Stack trace:
[task 2020-08-27T15:15:35.719Z] 15:15:35     INFO - chrome://mochikit/content/browser-test.js:test_ok:1304
[task 2020-08-27T15:15:35.719Z] 15:15:35     INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_parsable_css.js:checkAllTheCSS:460
[task 2020-08-27T15:15:35.719Z] 15:15:35     INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-08-27T15:15:35.720Z] 15:15:35     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_parsable_css.js | custom property `--device-button-active-background-color` is not referenced - 
[task 2020-08-27T15:15:35.720Z] 15:15:35     INFO - Stack trace:
[task 2020-08-27T15:15:35.720Z] 15:15:35     INFO - chrome://mochikit/content/browser-test.js:test_ok:1304
[task 2020-08-27T15:15:35.720Z] 15:15:35     INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_parsable_css.js:checkAllTheCSS:460
[task 2020-08-27T15:15:35.721Z] 15:15:35     INFO - Ignored error "Unknown pseudo-class or pseudo-element ‘-moz-has-dir-attr’.  Ruleset ignored due to bad selector." on resource://gre-resources/html.css because of whitelist item {"sourceName":"/\\b(contenteditable|EditorOverride|svg|forms|html|mathml|ua|pluginproblem)\\.css$/i","errorMessage":"/Unknown pseudo-class.*-moz-/i","isFromDevTools":false,"used":true}
...
...
...
[task 2020-08-27T15:15:35.776Z] 15:15:35     INFO - Ignored error "Expected media feature name but found ‘-moz-windows-default-theme’." on jar:file:///Z:/task_1598537966/build/application/firefox/browser/features/[e-mail]!/chrome/res/autocomplete-item.css because of whitelist item {"sourceName":"/\\b(autocomplete-item|svg|ua)\\.css$/","errorMessage":"/Expected media feature name but found \\u2018-moz.*/i","isFromDevTools":false,"used":true}
[task 2020-08-27T15:15:35.776Z] 15:15:35     INFO - TEST-PASS | browser/base/content/test/static/browser_parsable_css.js | All the styles (260) loaded without errors. - 
[task 2020-08-27T15:15:35.776Z] 15:15:35     INFO - Leaving test bound checkAllTheCSS
[task 2020-08-27T15:15:35.776Z] 15:15:35     INFO - GECKO(5732) | MEMORY STAT | vsize 2104728MB | vsizeMaxContiguous 67071575MB | residentFast 818MB | heapAllocated 613MB
[task 2020-08-27T15:15:35.776Z] 15:15:35     INFO - TEST-OK | browser/base/content/test/static/browser_parsable_css.js | took 867ms
[task 2020-08-27T15:15:35.776Z] 15:15:35     INFO - checking window state
[task 2020-08-27T15:15:35.776Z] 15:15:35     INFO - TEST-START | browser/base/content/test/static/browser_parsable_script.js
[task 2020-08-27T15:15:54.947Z] 15:15:54     INFO - GECKO(5732) | MEMORY STAT | vsize 2104669MB | vsizeMaxContiguous 67071575MB | residentFast 670MB | heapAllocated 441MB
[task 2020-08-27T15:15:54.947Z] 15:15:54     INFO - TEST-OK | browser/base/content/test/static/browser_parsable_script.js | took 19236ms

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8acfced551af
Add global mute/unmute capability for microphones, with tests. r=jib
https://hg.mozilla.org/integration/autoland/rev/2cd2f097bb46
Make MediaEngineDefaultAudioSource::Start idempotent per expectations. r=jib
https://hg.mozilla.org/integration/autoland/rev/1ed338e8d653
Add state for microphone muting to MediaManager. r=jib

Comment 9

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/8acfced551af
https://hg.mozilla.org/mozilla-central/rev/2cd2f097bb46
https://hg.mozilla.org/mozilla-central/rev/1ed338e8d653