1658356 - [compatibility tooltip] Wrong key usage while accessing compatibility message id

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, defect, P3)

Description

[Kriyszig]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:81.0) Gecko/20100101 Firefox/81.0

Steps to reproduce:

Line resulting in error: https://searchfox.org/mozilla-central/source/devtools/client/inspector/rules/models/text-property.js#347

1. Toggle devtools.inspector.ruleview.inline-compatibility-warning.enabled pref to true
2. Go to https://developer.mozilla.org/en-US/
3. Inspect the Learn web development button
4. Hover over the tooltip icon

Actual results:

The tooltip doesn't show logging an error in the browser console

Expected results:

The tooltip should appear with experimental warning but supported on all platform

Comment 1

[Kriyszig]

Attachment: Bug 1658356 - Fix the incorrect object key for the Tooltip message ID r=daisuke,mtigley

The key of the object is incorrectly used as css-compatibility-experimental-supported-message
instead of experimental-supported. This leads to the l10n translation
for undefined msgId leading to failure of appearance of tooltip.
This patch fixes the problem and adds a test to prevent regression.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ebe12173ab02
Fix the incorrect object key for the Tooltip message ID r=daisuke,mtigley

Comment 3

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/ebe12173ab02