1658387 - "Clear Log" button went missing in about:webrtc

Status: VERIFIED FIXED

(Core :: WebRTC, defect, P2)

Description

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

This is annoying since it leaves the user with no way to clear the log. Broken by accidental omission in refactor.

Comment 1

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

[Tracking Requested - why for this release]: See comment 0. Super trivial fix.

Comment 2

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: Bug 1658387 - Bring back "Clear Log" button in about:webrtc that was removed by accident.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c01284919b27
Bring back "Clear Log" button in about:webrtc that was removed by accident. r=ng

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/c01284919b27

Comment 5

[Julien Cristau [:jcristau]]

Care to request uplift if this is verified in nightly?

Comment 6

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

I've verified this is fixed in Nightly.

Comment 7

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Comment on attachment 9169240 [details]
Bug 1658387 - Bring back "Clear Log" button in about:webrtc that was removed by accident.

Beta/Release Uplift Approval Request

• User impact if declined: The user has no way to clear the WebRTC log in about:webrtc (e.g. to help provide useful logs to support to help diagnose a problem after certain steps), since it's a rolling log.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Open https://jsfiddle.net/jib1/yxbLvjm6/ and share camera+mic. Then visit about:webrtc and look for and press the "Clear Log" button, which should clear the log below (the button is not present without this fix).
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Super trivial patch. Creation of button lost in refactor.
• String changes made/needed: None

Comment 8

[Alin Ilea, Desktop QA]

Reproduced the issue using Beta 80.0b7 (build id: 20200811133449).
Verified - Fixed in latest Nightly 81.0a1 (build id: 20200812214948) on Windows 10 and Ubuntu 18.04. The "Clear Log" button is displayed and by click on it the "show log" section is removed, the log is cleared.

Comment 9

[Julien Cristau [:jcristau]]

Comment on attachment 9169240 [details]
Bug 1658387 - Bring back "Clear Log" button in about:webrtc that was removed by accident.

about:webrtc regression fix, approved for 80.0b8

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/1dc8beafadf6

Comment 11

[Alin Ilea, Desktop QA]

Verified - Fixed in latest Beta 80.0b8 (build id: 20200813191622) on Windows 10 and Ubuntu 18.04. The "Clear Log" button is displayed.