1658416 - Change Gamepad testing to function more like platform monitor code

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Chris Martin [:cmartin]]

Currently, the GamepadTestChannel immediately calls into GamepadPlatformService when it receives a message, but that goes against the way that GamepadPlatformService was designed - It doesn't really expect to receive messages until a GamepadEventChannel is created and monitoring is started.

We should change GamepadTestChannel to wait until monitoring starts to allow simulated events to flow, and block them after monitoring stops.

Comment 1

[Chris Martin [:cmartin]]

Attachment: Bug 1658416 - Remove current pending events handling

The "pending events" functionality is going to be taken by the test channel
itself, so this code is no longer needed

Comment 2

[Chris Martin [:cmartin]]

Attachment: Bug 1658416 - Allow gamepad test channel to observe gamepad monitoring state

Each existing GamepadTestChannel needs to know when gamepad monitoring is
started or stopped so it knows whether it's safe to deliver messages.

Depends on D86746

Comment 3

[Chris Martin [:cmartin]]

Attachment: Bug 1658416 - Defer simulated gamepad adds until monitoring starts

Since the test code will be waiting on a promise from the addGamepad message,
we can simply defer fulfilling the promise until monitoring starts if it
hasn't already.

Since every other message relies on the index given by the fulfilled promise,
it ensures that we won't get any simulated events until monitoring starts

Depends on D86747

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a1b892fa5d21
Remove current pending events handling r=baku
https://hg.mozilla.org/integration/autoland/rev/ed5c70dc6a6c
Allow gamepad test channel to observe gamepad monitoring state r=handyman
https://hg.mozilla.org/integration/autoland/rev/b7881b750473
Defer simulated gamepad adds until monitoring starts r=handyman

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/a1b892fa5d21
https://hg.mozilla.org/mozilla-central/rev/ed5c70dc6a6c
https://hg.mozilla.org/mozilla-central/rev/b7881b750473