1658534 - Make `HTMLEditor::HandleDeleteCollapsedSelectionAtAtomicContent()` stop recursive call

Status: RESOLVED FIXED

(Core :: DOM: Editor, task, P2)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

When it removes an invisible <br> element, it calls HandleDeleteSelectionInternal() recursively to delete its preceding content. However, now, we must be able to compute the preceding content's range and delete it without the dangerous recursive call.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1658534 - part 1: Split the removing invisible `<br>` element part off from `HTMLEditor::HandleDeleteCollapsedSelectionAtAtomicContent()` r=m_kato!

Depends on D86886

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1658534 - part 2: Avoid infinite recursive calls at removing an invisible `<br>` element r=m_kato!

Depends on D86909

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/361b77c4aaa2
part 1: Split the removing invisible `<br>` element part off from `HTMLEditor::HandleDeleteCollapsedSelectionAtAtomicContent()` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/fe37e2106c17
part 2: Avoid infinite recursive calls at removing an invisible `<br>` element r=m_kato

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/361b77c4aaa2
https://hg.mozilla.org/mozilla-central/rev/fe37e2106c17