1658536 - Encapsulate `HTMLEditor::HandleDeleteSelectionInternal()` and helper methods into a stack only class

Status: RESOLVED FIXED

(Core :: DOM: Editor, task, P2)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

For managing recursive calls, it should be reimplemented with a new stack only class.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1658536 - part 1: Move methods called by `HTMLEditor::HandleDeleteSelectionInternal()` to `AutoDeleteRangesHandler` r=m_kato!

This patch just moves them into the new stack only class and make each of them
take HTMLEditor& as their first argument.

Depends on D87035

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1658536 - part 2: Move `AutoBlockElementsJoiner` and `AutoInclusiveAncestorBlockElementsJoiner` into `AutoDeleteRangesHandler` r=m_kato!

Even though their method names in stack trace become too long, but we can
guarantee that they are used only at handling deletion.

Depends on D87432

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1658536 - part 3: Move `HTMLEditor::SelectionWasCollapsed` into `AutoDeleteRangesHandler` r=m_kato!

Depends on D87433

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1658536 - part 4: Move some methods used only in `AutoDeleteRangesHandler` into the class r=m_kato!

Depends on D87434

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1658536 - part 5: Move `HTMLEditor::HandleDeleteSelectionInternal()` into `AutoDeleteRangesHandler` r=m_kato!

Depends on D87435

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1658536 - part 6: Move `AutoEmptyBlockAncestorDeleter` into `AutoDeleteRangesHandler` r=m_kato!

Depends on D87436

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1658536 - part 7: Make `HTMLEditor::HandleDeleteSelection()` stop calling `DeleteRangesWithTransaction()` a fallback when `AutoDeleteRangesHandler::Run()` returns "ignored" r=m_kato!

For avoiding infinite recursive calls, AutoDeleteRangesHandler returns
EditActionIgnored() when it needs to fall it back to
DeleteRangesWithTransaction() after modifying the DOM tree or the ranges
to delete. However, this makes developers understand the code harder.
And now, with making constructor of AutoDeleteRangesHandler manage the
recursive call state, we can make HandleDeleteSelection() stop handling
the fallback path.

Depends on D87437

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1658536 - part 8: Make `AutoBlockElementsJoiner::HandleDeleteCollapsedSelectionAtOtherBlockBoundary()` creates another instance of `AutoDeleteRangesHandler` by itself r=m_kato!

When it returns EditActionIgnored(),
AutoDeleteRangesHandler::HandleDeleteAroundCollapsedRanges() creates another
AutoDeleteRangesHandler instance to delete leaf content node in another
block element. However, this dependency makes developers understand the
behavior harder. Therefore, we should make the method do it instead.

Depends on D87438

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cfcc43e6e3b3
part 1: Move methods called by `HTMLEditor::HandleDeleteSelectionInternal()` to `AutoDeleteRangesHandler` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/f79a9d5e908a
part 2: Move `AutoBlockElementsJoiner` and `AutoInclusiveAncestorBlockElementsJoiner` into `AutoDeleteRangesHandler` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/f47acf69dc40
part 3: Move `HTMLEditor::SelectionWasCollapsed` into `AutoDeleteRangesHandler` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/28af71207f2e
part 4: Move some methods used only in `AutoDeleteRangesHandler` into the class r=m_kato
https://hg.mozilla.org/integration/autoland/rev/0249f69af08d
part 5: Move `HTMLEditor::HandleDeleteSelectionInternal()` into `AutoDeleteRangesHandler` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/0698263c5203
part 6: Move `AutoEmptyBlockAncestorDeleter` into `AutoDeleteRangesHandler` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/5550f1f7b49d
part 7: Make `HTMLEditor::HandleDeleteSelection()` stop calling `DeleteRangesWithTransaction()` a fallback when `AutoDeleteRangesHandler::Run()` returns "ignored" r=m_kato
https://hg.mozilla.org/integration/autoland/rev/22d075d9eec9
part 8: Make `AutoBlockElementsJoiner::HandleDeleteCollapsedSelectionAtOtherBlockBoundary()` creates another instance of `AutoDeleteRangesHandler` by itself r=m_kato

Comment 10

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/cfcc43e6e3b3
https://hg.mozilla.org/mozilla-central/rev/f79a9d5e908a
https://hg.mozilla.org/mozilla-central/rev/f47acf69dc40
https://hg.mozilla.org/mozilla-central/rev/28af71207f2e
https://hg.mozilla.org/mozilla-central/rev/0249f69af08d
https://hg.mozilla.org/mozilla-central/rev/0698263c5203
https://hg.mozilla.org/mozilla-central/rev/5550f1f7b49d
https://hg.mozilla.org/mozilla-central/rev/22d075d9eec9