1658563 - Problems with local file links since 78esr

Status: VERIFIED FIXED

(Core :: Networking: File, defect, P1)

Description

[Malte]

Attachment: firefox_bug.PNG

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0

Steps to reproduce:

We have HTML-links in our intranet which refer to local lnk-files. This lnk-Files refer to local Word-Templates.

Actual results:

FF offers to download the lnk-files instead of opening the refered Word-Templates. In our group-policy we defined everything correct for handling with local files from our intranet-ressource.
The problems occur since FF 78esr. IN FF 68esr everything was OK.

Expected results:

The refered lnk-files shoudl open the refered word-templates.

Comment 1

[Mike Kaply [:mkaply]]

I can confirm this and that it worked in Firefox 68. Just take a file on Windows, right click, create shortcut.

try to open the shortcut in Firefox and it tries to download the LNK file.

In Firefox 68, it tried to download the corresponding file.

Comment 2

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=4ff7fb7b96694b162de6a7f455121b7cee01973d&tochange=04fe21d06acd65d39e5e23bc1a156a6b0b637e29

Comment 3

[:Gijs (he/him)]

[Tracking Requested - why for this release]:
Broke end-user usage of lnk files.

Mike, there's a partial backout suggestion in bug 1466532 for esr78; is this something you can pursue?

Comment 4

[Mike Kaply [:mkaply]]

Attachment: Bug 1658563 - Backout bug 1466532 on ESR to fix LNK files on Windows. r?Gijs!

Comment 5

[Mike Kaply [:mkaply]]

Comment on attachment 9173378 [details]
Bug 1658563 - Backout bug 1466532 on ESR to fix LNK files on Windows. r?Gijs!

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Regression opening local LNKs in ESR
• User impact if declined: Unable to open LNK files
• Fix Landed on Version: N/A
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Backs out existing patch for ESR only.
• String or UUID changes made by this patch:

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Do we need this backout on Beta also given where we are in the cycle?

Comment 7

[Mike Kaply [:mkaply]]

Do we need this backout on Beta also given where we are in the cycle?

In bug 1466532, the folks that broke this believe the patch should stay in and get fixed later in the cycle. (I don't necessarily agree).

Because this would primarily impact enterprise users, we are backing out of the ESR only.

I was hopeful they would have a patch for 81, but I'm not optimistic at this point.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9173378 [details]
Bug 1658563 - Backout bug 1466532 on ESR to fix LNK files on Windows. r?Gijs!

Approved for 78.3esr.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr78/rev/9c36779c658a

Comment 10

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1658563 - Support .lnk files in file: protocol

Comment 11

[Mike Kaply [:mkaply]]

Who needs to be pinged to review this?

Comment 12

[:Gijs (he/him)]

(In reply to Mike Kaply [:mkaply] from comment #11)

Who needs to be pinged to review this?

Valentin, can you help find a reviewer? Thank you!

Comment 13

[Valentin Gosu [:valentin] (he/him)]

Dragana offered to review it.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e5410b9f33e1
Support .lnk files in file: protocol r=necko-reviewers,dragana

Comment 15

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/e5410b9f33e1

Comment 16

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:mkaply, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 17

[Mike Kaply [:mkaply]]

Comment on attachment 9175825 [details]
Bug 1658563 - Support .lnk files in file: protocol

Beta/Release Uplift Approval Request

• User impact if declined: Local file LNKs no longer redirect.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Right click on a file like a PDF to create a LNK file on your local system.
  Navigate to that file using Firefox (file:///)
  Verify that when you click the LNK, it opens the original file.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Automated test, fixes regression.
• String changes made/needed:

Comment 18

[Julien Cristau [:jcristau]]

Comment on attachment 9173378 [details]
Bug 1658563 - Backout bug 1466532 on ESR to fix LNK files on Windows. r?Gijs!

presumably we don't actually want this one on beta

Comment 19

[Julien Cristau [:jcristau]]

Comment on attachment 9175825 [details]
Bug 1658563 - Support .lnk files in file: protocol

approved for 82.0b4

Comment 20

[Julien Cristau [:jcristau]]

https://hg.mozilla.org/releases/mozilla-beta/rev/eb046439b26f

Comment 21

[Timea Cernea [:tbabos][inactive]]

Reproduced the issue on affected Release Version 81.
Verified-fixed on latest Nightly 83.0a1 (2020-09-28), Beta 82.0b4 and ESR 78.3.0esr on the following OS:

• Windows 10 x86/x64
• Windows 7 x64
• Windows 8.1 x86

The shortcuts of word, ppt, excel and other documents will no longer offer to download/handle the .lnk files instead of the actual document.