Account Settings, end-to-end encryption, shows exception after changing mail.openpgp.enable to true
Categories
(MailNews Core :: Security: OpenPGP, defect)
Tracking
(Not tracked)
People
(Reporter: KaiE, Unassigned)
References
Details
If the preference value mail.openpgp.enable was "false" at thunderbird start time, and the value is changed to "true" at runtime, then an attempt to open the account settings, end-end-encryption tab will fail and produce an exception.
The reason is that there is a lot of dynamic code that depends on the pref, and that code doesn't watch for a pref change.
This might only be seen after bug 1656287, which adds code that allows a change at runtime to take effect.
I'd prefer to accept this consequence, and still proceed with bug 1656287.
|
||
Comment 1•5 years ago
|
||
Can bug 1656287 force a restart then?
|
Reporter | |
Comment 2•5 years ago
|
||
(In reply to Magnus Melin [:mkmelin] from comment #1)
Can bug 1656287 force a restart then?
The code in bug 1656287 does not know that Enigmail has completed a migration. Bug 1656287 repairs a broken profile on startup, and doesn't require a restart.
It's the Enigmail migrator that would have to force a restart.
|
|
Reporter | |
Comment 3•5 years ago
|
||
Maybe I misunderstood.
Are you suggestion that Thunderbird should force a restart at the time it detects that mail.openpgp.enable is switched to true?
We could do that, but if we do that without prompting the user, then the user might lose the contents of open windows?
If we do that with prompting, then we'll require a new string?
|
|
||
Comment 4•5 years ago
|
||
It's the Enigmail migrator that would have to force a restart.
Maybe that's best yes.
I don't think Thunderbird should force a restart.
|
|
Reporter | |
Comment 5•5 years ago
|
||
I guess we won't need this anymore, after Enigmail migrator 2.2.1 has added automatic restarted, and once we enable by default in bug 1659536.
Description
•