1658614 - Capture renamed media thread `media controller`

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[Alastor Wu [:alwu]]

In [1], it renamed MediaPlayback thread to MediaController but the profiler is still capturing the old name.

We should change the profiler preset in order to capture that thread with new name correctly.

[1] https://phabricator.services.mozilla.com/D85543

Comment 1

[Alastor Wu [:alwu]]

Hi, canaltinova,
Do you know where we decide what thread we would capture for media preset? could you point me out where I should modify the code?
Thank you.

Comment 2

[Nazım Can Altınova [:canova][:canaltinova on phabricator]]

Hey Alastor,
We have an object that hold all the preset values here: https://searchfox.org/mozilla-central/rev/8df04ff073d0fa70f692935c5dcddc0e23cb0117/devtools/client/performance-new/popup/background.jsm.js#86-137
And this is MediaPlayback thread for media preset: https://searchfox.org/mozilla-central/rev/8df04ff073d0fa70f692935c5dcddc0e23cb0117/devtools/client/performance-new/popup/background.jsm.js#129
We don't have a test for this, so changing only this place should be enough. Let me know if you need any help!

Comment 3

[Alastor Wu [:alwu]]

Thank you so much, will have a patch for that.

Comment 4

[Alastor Wu [:alwu]]

Attachment: Bug 1658614 - capture 'MediaController' thread in media preset.

MediaPlayback thread has been renamed to MediaController thread, so update the captured thread list for media preset.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/585a5613ef44
capture 'MediaController' thread in media preset. r=canaltinova

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/585a5613ef44