Closed
Bug 1658708
Opened 5 years ago
Closed 5 years ago
Do not call get_marker_timing_from_payload or create a MarkerTiming when profiler is not active
Categories
(Core :: Gecko Profiler, task, P1)
Core
Gecko Profiler
Tracking
()
RESOLVED
FIXED
81 Branch
| Tracking | Status | |
|---|---|---|
| firefox81 | --- | fixed |
People
(Reporter: canova, Assigned: canova)
Details
Attachments
(1 file)
Currently racy_profiler_add_marker requires a MarkerTiming instance. But we are actually checking if profiler is active or not inside the racy_profiler_add_marker function. So we are creating a MarkerTiming even profiler is not active, or the thread is not being profiled. We can just move that initialization after that check to get rid of those unused intermediate object instances.
Severity: -- → S4
Priority: -- → P1
|
Assignee | |
Comment 1•5 years ago
|
||
Pushed by canaltinova@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/8ddec38d3444
Do not create a MarkerTiming when profiler is not active. r=gerald
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox81:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•