1658710 - Crash in [@ mozilla::AppWindow::GetPrimaryRemoteTabSize]

Status: RESOLVED WORKSFORME

(Core :: Window Management, defect, P3)

Description

[Simon Giesecke [:sg] [he/him]]

This bug is for crash report bp-6297347f-8673-4ff2-b0b5-29d790200525.

Top 10 frames of crashing thread:

0 xul.dll mozilla::AppWindow::GetPrimaryRemoteTabSize xpfe/appshell/AppWindow.cpp:2061
1 xul.dll static nsWindowWatcher::SizeOpenedWindow toolkit/components/windowwatcher/nsWindowWatcher.cpp:2220
2 xul.dll nsWindowWatcher::OpenWindowWithRemoteTab toolkit/components/windowwatcher/nsWindowWatcher.cpp:575
3 xul.dll mozilla::dom::ContentParent::CommonCreateWindow dom/ipc/ContentParent.cpp:4760
4 xul.dll mozilla::dom::ContentParent::RecvCreateWindowInDifferentProcess dom/ipc/ContentParent.cpp:4938
5 xul.dll mozilla::dom::PContentParent::OnMessageReceived ipc/ipdl/PContentParent.cpp:9996
6 xul.dll mozilla::ipc::MessageChannel::DispatchMessage ipc/glue/MessageChannel.cpp:2111
7 xul.dll mozilla::ipc::MessageChannel::MessageTask::Run ipc/glue/MessageChannel.cpp:1990
8 xul.dll nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1220
9 xul.dll NS_ProcessNextEvent xpcom/threads/nsThreadUtils.cpp:481

The number of reports is low, but it looks as if AppWindow::GetPrimaryRemoteTabSize is missing a nullptr check on mPrimaryBrowserParent. AppWindow::GetLiveResizeListeners has a nullptr check, e.g.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:enndeakin, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Neil Deakin]

All of the callers already seem to null-check mPrimaryBrowserParent, so unclear what the issue is here.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Closing because no crashes reported for 12 weeks.