Closed Bug 1658720 Opened 4 years ago Closed 4 years ago

Combine ScriptStencil topLevel/funcData structures

Categories

(Core :: JavaScript Engine, task, P2)

task

Tracking

()

RESOLVED FIXED
82 Branch
Tracking Status
firefox82 --- fixed

People

(Reporter: tcampbell, Assigned: tcampbell)

References

Details

Attachments

(1 file)

Now that we've unified the stencil data for BaseScript / JSFunction and are preparing to factor out the GC results, it may be helpful to combine the topLevel and funcData fields. This would resolve some confusion when compiling standalone functions that have two stencils but only one is used.

This should also let us remove isStandaloneFunction

Instead, rename funcData to scriptData and reserve index 0 for top-level.

Attachment #9170023 - Attachment description: Bug 1658720 - Remove CompilationInfo::topLevel → Bug 1658720 - Remove CompilationInfo::topLevel. r?arai
Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/autoland/rev/d612e1883efc Remove CompilationInfo::topLevel. r=arai
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 82 Branch
Regressions: 1662113
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: