1658811 - Warp: Transpile Function.prototype.apply arguments optimization

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P1)

Description

[Iain Ireland [:iain]]

These patches implement FunApplyArgs. I'll do FunApplyArray in a separate bug.

Comment 1

[Iain Ireland [:iain]]

Attachment: Bug 1658811: Clean up tryAttachFunApply r=jandem

1. tryAttachFunApply was the last remaining use of GuardSpecificNativeFunction.
2. The FunApplyArgs side of GuardFunApply can be reimplemented using existing CacheIR ops. We might be able to do a similar thing with GuardFunApplyArray, but it will require a bit of refactoring, so I'm leaving it as its own op for now.
3. Like FunCall, FunApply now has a Specialized variant that guards on the specific target to make inlining easier.

Comment 2

[Iain Ireland [:iain]]

Attachment: Bug 1658811: Transpile GuardNotClassConstructor r=jandem

Depends on D86856

Comment 3

[Iain Ireland [:iain]]

Attachment: Bug 1658811: Transpile function flag guards r=jandem

GuardFunctionIsConstructor isn't necessary for FunApplyArgs, but it seemed reasonable to implement it now anyway.

Depends on D86857

Comment 4

[Iain Ireland [:iain]]

Attachment: Bug 1658811: Transpile FunApplyArgs r=jandem

Depends on D86858

Comment 5

[Iain Ireland [:iain]]

Attachment: Bug 1658811: Use the correct arguments when transpiling inside an inlined function r=jandem

We didn't have very good jit-test coverage of this code, so I'm also adding a simple testcase.

Comment 6

[Iain Ireland [:iain]]

Attachment: Bug 1658811: Unify funapply/spread args limits between CacheIR and MIR r=jandem

It appears that the existing limit of 16 args for CacheIR was established when we first added FunApplyArray support in bug 906781 and never revisited.

Depends on D87681

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/85471158d0c5
Clean up tryAttachFunApply r=jandem
https://hg.mozilla.org/integration/autoland/rev/9e22306cf2a2
Transpile GuardNotClassConstructor r=jandem
https://hg.mozilla.org/integration/autoland/rev/f359af39ebfa
Transpile function flag guards r=jandem
https://hg.mozilla.org/integration/autoland/rev/a0457890d336
Transpile FunApplyArgs r=jandem
https://hg.mozilla.org/integration/autoland/rev/0a552e8d736a
Use the correct arguments when transpiling inside an inlined function r=jandem
https://hg.mozilla.org/integration/autoland/rev/49ad63d4238d
Unify funapply/spread args limits between CacheIR and MIR r=jandem

Comment 8

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/85471158d0c5
https://hg.mozilla.org/mozilla-central/rev/9e22306cf2a2
https://hg.mozilla.org/mozilla-central/rev/f359af39ebfa
https://hg.mozilla.org/mozilla-central/rev/a0457890d336
https://hg.mozilla.org/mozilla-central/rev/0a552e8d736a
https://hg.mozilla.org/mozilla-central/rev/49ad63d4238d