Change profile count to use IOUtils
Categories
(Firefox :: Shell Integration, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox84 | --- | fixed |
People
(Reporter: bytesized, Assigned: masterwayz, Mentored)
References
Details
(Whiteboard: [lang=js])
Attachments
(1 file)
|
Bug 1658828 - Change OS.File in BrowserUsageTelemetry and test with new IOUtils equivalent r=emalysz
47 bytes,
text/x-phabricator-request
|
Details | Review |
The profile count telemetry collection (added in Bug 1647422) currently uses OS.File. It should be pretty simple to switch it over.
Make sure to also change the test code (test_ProfileCounter.js). It simulates some I/O errors for testing, and they will need to be switched over to look more like the errors we will get from IOUtils (which I believe will are DOMExceptions),
|
||
Comment 1•4 years ago
|
||
To use IOUtils, we should look at replacing these instances of OS.File https://searchfox.org/mozilla-central/rev/d25eb00ab4e90cc0130cd18f303a04cc2a2f8409/browser/modules/BrowserUsageTelemetry.jsm#422,424, as well as the errors mentioned above. We should be able to use the equivalent IOUtils functions https://searchfox.org/mozilla-central/rev/d25eb00ab4e90cc0130cd18f303a04cc2a2f8409/dom/chrome-webidl/IOUtils.webidl#44,62
|
Assignee | |
Comment 2•4 years ago
|
||
|
||
Updated•4 years ago
|
Pushed by emalysz@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6655ef1c7727 Change OS.File in BrowserUsageTelemetry and test with new IOUtils equivalent r=emalysz
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
Description
•