Closed Bug 1658828 Opened 4 years ago Closed 4 years ago

Change profile count to use IOUtils

Categories

(Firefox :: Shell Integration, task)

task

Tracking

()

RESOLVED FIXED
84 Branch
Tracking Status
firefox84 --- fixed

People

(Reporter: bytesized, Assigned: masterwayz, Mentored)

References

Details

(Whiteboard: [lang=js])

Attachments

(1 file)

The profile count telemetry collection (added in Bug 1647422) currently uses OS.File. It should be pretty simple to switch it over.

Make sure to also change the test code (test_ProfileCounter.js). It simulates some I/O errors for testing, and they will need to be switched over to look more like the errors we will get from IOUtils (which I believe will are DOMExceptions),

To use IOUtils, we should look at replacing these instances of OS.File https://searchfox.org/mozilla-central/rev/d25eb00ab4e90cc0130cd18f303a04cc2a2f8409/browser/modules/BrowserUsageTelemetry.jsm#422,424, as well as the errors mentioned above. We should be able to use the equivalent IOUtils functions https://searchfox.org/mozilla-central/rev/d25eb00ab4e90cc0130cd18f303a04cc2a2f8409/dom/chrome-webidl/IOUtils.webidl#44,62

Mentor: emalysz
Whiteboard: [lang=js]
Assignee: nobody → michael
Status: NEW → ASSIGNED
Pushed by emalysz@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6655ef1c7727 Change OS.File in BrowserUsageTelemetry and test with new IOUtils equivalent r=emalysz
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 84 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: