1658831 - Thread name annotations missing from OSX

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect, P1)

Description

[Andrew McCreight (out of office until 8/21) [:mccr8]]

I was looking at a lot of crashes lately, and I noticed the OSX ones seem to be missing thread names. For instance, bp-e4eb5f07-00c9-474d-9320-059be0200809

I'm not sure where this could be going wrong, but the crash report does have ThreadIdNameMapping under metadata, so maybe the issue is somewhere in Socorro?

Here's an example of a Windows crash that does have thread names annotated (though the main thread and some others aren't annotated). bp-e9650294-215a-4612-818a-07f0f0200812

Linux also seems to be okay: bp-ddaaefa0-61cb-488d-a655-0fb920200812

Comment 1

[Gabriele Svelto [:gsvelto]]

This is actually a bug in crash generation. We use the id we store in the thread annotation to find the corresponding threads in the minidump and generate the mapping but the two don't correspond on macOS. The annotations is just an index while the minidump stores the mach port.

This should be an easy fix.

Comment 2

[Gabriele Svelto [:gsvelto]]

Tentative fix: https://treeherder.mozilla.org/#/jobs?repo=try&revision=bb66e984894dca5b09eda8d88d204bbb85bc7ae1

Comment 3

[Gabriele Svelto [:gsvelto]]

I'm working on this. I won't fix the existing code that uses the ThreadIdNameMapping annotation but rather write the names directly into the minidump's ThreadNamesStream. This won't be immediately accessible on crash-stats until we update minidump-stackwalk there, which should happen soon next month.

Comment 4

[Gabriele Svelto [:gsvelto]]

Attachment: Bug 1658831 - Implement a writer for the thread names' minidump stream on macOS r=gankra

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/63e43c6f4114
Implement a writer for the thread names' minidump stream on macOS r=Gankra

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/63e43c6f4114