Closed Bug 1658870 Opened 5 months ago Closed 5 months ago

Firefox version check in acceptInsecureCerts doesn't allow to start Firefox via a shell script

Categories

(Testing :: geckodriver, defect, P1)

Firefox 81
defect

Tracking

(firefox-esr68 unaffected, firefox-esr78 wontfix, firefox79 wontfix, firefox80 wontfix, firefox81 fixed)

RESOLVED FIXED
81 Branch
Tracking Status
firefox-esr68 --- unaffected
firefox-esr78 --- wontfix
firefox79 --- wontfix
firefox80 --- wontfix
firefox81 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

(Regression, )

Details

(Keywords: regression)

Attachments

(1 file)

The changes from bug 1648964 caused the version of Firefox to not only report the actual release number, but also the Mozilla Firefox prefix when a shell script is used to start Firefox - which mostly happens on Linux.

The underlying problem here as identified on Github is that there is an extra version check for the acceptInsecureCerts capability:

https://github.com/mozilla/geckodriver/blob/917daaccc78bb8cac3ab324861ada48d68746d13/src/capabilities.rs#L134-L145

Given that our minimal supported release of Firefox is 60 now, we can get rid of that check.

Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/46b078983080
[geckodriver] Remove Firefox version check for acceptInsecureCerts. r=webdriver-reviewers,jgraham
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 81 Branch

Does this need to be uplifted to Beta/ESR78? Please nominate if so :)

Flags: needinfo?(hskupin)

People don't usually build on old checkouts, and starting from the 0.27.0 release of geckodriver we allow folks to build directly from Github. So I don't think that we should backport this patch.

You need to log in before you can comment on or make changes to this bug.